test: remove unnecessary test flags #25277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BridgeAR
approved these changes
Dec 30, 2018
Trott
reviewed
Dec 30, 2018
| @@ -1,4 +1,3 @@ | |||
| // Flags: --pending-deprecation --no-warnings | |||
There was a problem hiding this comment.
Should the same flags in test-buffer-of-no-deprecation be removed?
addaleax
approved these changes
Dec 30, 2018
lpinca
approved these changes
Dec 30, 2018
Trott
added
the
author ready
This commit removes unnecessary flags used when starting tests via the "// Flags:" directive. PR-URL: nodejs#25277 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jan 5, 2019
This commit removes unnecessary flags used when starting tests via the "// Flags:" directive. PR-URL: #25277 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
This commit removes unnecessary flags used when starting tests via the "// Flags:" directive. PR-URL: nodejs#25277 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
This commit removes unnecessary flags used when starting tests via the "// Flags:" directive. PR-URL: nodejs#25277 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes unnecessary flags used when starting tests via the
"// Flags:"directive.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes