Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add class: worker documentation #24809

Closed
wants to merge 8 commits into from

Conversation

yoshimoto8
Copy link
Contributor

Add documentation about Worker class inherits from EventEmitter.

related #24732

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows [commit guidelines]

Add documentation about Worker class inherits from EventEmitter.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 3, 2018
@yoshimoto8 yoshimoto8 changed the title Add doc worker doc: Add Class: Worker documentation Dec 3, 2018
@vsemozhetbyt
Copy link
Contributor

cc @nodejs/workers

@vsemozhetbyt vsemozhetbyt added the worker Issues and PRs related to Worker support. label Dec 3, 2018
@lpinca
Copy link
Member

lpinca commented Dec 3, 2018

Can we use extends instead like it's done for MessagePort? See https://github.com/nodejs/node/blob/2e03b76bcf9e8d84862942a557a09af47d105d5f/doc/api/worker_threads.md#class-messageport

@yoshimoto8 yoshimoto8 changed the title doc: Add Class: Worker documentation doc: add class: worker documentation Dec 5, 2018
Since ci failed, it is recommitted and fixed indent num and english grammar.
Add documentation about worker class inherits from eventEmitter.
Since ci failed, it is recommitted and fixed indent num and english grammar.
@lpinca
Copy link
Member

lpinca commented Dec 11, 2018

Superseded by #24849

@lpinca lpinca closed this Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants