Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: patch V8 to 7.0.276.32 #23851

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 7.0.276.32 #23851

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 24, 2018

@targos targos added v8 engine Issues and PRs related to the V8 dependency. dont-land-on-v6.x labels Oct 24, 2018
@nodejs-github-bot

This comment has been minimized.

Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp.

@targos
Copy link
Member Author

targos commented Oct 27, 2018

I need another approval, please.

Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@refack
Copy link
Contributor

refack commented Oct 27, 2018

P.S. if you rebase this, it should pass Travis.

targos added a commit to targos/node that referenced this pull request Oct 28, 2018
Refs: v8/v8@7.0.276.28...7.0.276.32

PR-URL: nodejs#23851
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@targos
Copy link
Member Author

targos commented Oct 28, 2018

Landed in 124d916

@targos targos closed this Oct 28, 2018
@targos targos deleted the update-v8 branch October 28, 2018 09:19
targos added a commit that referenced this pull request Oct 28, 2018
Refs: v8/v8@7.0.276.28...7.0.276.32

PR-URL: #23851
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos added a commit that referenced this pull request Nov 1, 2018
Refs: v8/v8@7.0.276.28...7.0.276.32

PR-URL: #23851
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants