Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: fix length argument to snprintf() #23622

Closed
wants to merge 1 commit into from
Closed

crypto: fix length argument to snprintf() #23622

wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

Introduced in commit d3d6cd3 ("src: improve SSL version extraction
logic".)

@bnoordhuis
crypto: fix length argument to snprintf()
f4337a0 
Introduced in commit d3d6cd3 ("src: improve SSL version extraction
logic".)
@nodejs-github-bot
Copy link
Collaborator

@bnoordhuis build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1216/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Oct 12, 2018
@bnoordhuis bnoordhuis mentioned this pull request Oct 12, 2018
Closed
4 tasks
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/17763/

Collaborators, please 👍 this commit to approve fast-tracking.

@addaleax addaleax added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 12, 2018
@Trott
Copy link
Member

Trott commented Oct 13, 2018 •
edited
Loading

Resume Build: CI: https://ci.nodejs.org/job/node-test-pull-request/1​77​86

Trott pushed a commit to Trott/io.js that referenced this pull request Oct 13, 2018
@bnoordhuis @Trott
crypto: fix length argument to snprintf()
9ed4646 
Introduced in commit d3d6cd3 ("src: improve SSL version extraction
logic".)

PR-URL: nodejs#23622
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@Trott
Copy link
Member

Trott commented Oct 13, 2018

Landed in 9ed4646

@Trott Trott closed this Oct 13, 2018
addaleax pushed a commit that referenced this pull request Oct 14, 2018
@bnoordhuis @addaleax
crypto: fix length argument to snprintf()
104f099 
Introduced in commit d3d6cd3 ("src: improve SSL version extraction
logic".)

PR-URL: #23622
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@bnoordhuis @jasnell
crypto: fix length argument to snprintf()
cb569a3 
Introduced in commit d3d6cd3 ("src: improve SSL version extraction
logic".)

PR-URL: #23622
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@bnoordhuis @MylesBorins
crypto: fix length argument to snprintf()
a354091 
Introduced in commit d3d6cd3 ("src: improve SSL version extraction
logic".)

PR-URL: #23622
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@bnoordhuis @rvagg
crypto: fix length argument to snprintf()
eea759f 
Introduced in commit d3d6cd3 ("src: improve SSL version extraction
logic".)

PR-URL: #23622
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@bnoordhuis @MylesBorins
crypto: fix length argument to snprintf()
a81696a 
Introduced in commit d3d6cd3 ("src: improve SSL version extraction
logic".)

PR-URL: #23622
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@digitalinfinity digitalinfinity digitalinfinity approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@santigimeno santigimeno santigimeno approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@bnoordhuis @nodejs-github-bot @addaleax @Trott @refack @digitalinfinity @jasnell @santigimeno @cjihrig @richardlau