Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update AUTHORS file, add tool for doing it #232

Closed
wants to merge 2 commits into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jan 2, 2015

Update the list to give a bit of love to those who have contributed.

Generated automatically from the git log, see attached tool, still needs to be done regularly

@rvagg rvagg force-pushed the update-authors branch 2 times, most recently from acc3c91 to 45dc9b8 Compare January 2, 2015 05:18
@@ -151,6 +149,7 @@ Theo Schlossnagle <jesus@omniti.com>
Kai Chen <kaichenxyz@gmail.com>
Daniel Chcouri <333222@gmail.com>
Mihai Călin Bazon <mihai@bazon.net>
Kevin Millikin <kmillikin@chromium.org>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chromium.org addresses should be filtered out. Those come from cherry-picked V8 patches; their authors didn't contribute to node.js, they contributed to V8.

@bnoordhuis
Copy link
Member

I like where this is going but it still needs some .mailmap tweak to flush out duplicates / people contributing from different email addresses.

@rvagg
Copy link
Member Author

rvagg commented Jan 3, 2015

See 7c29bf7 for .mailmap updates and script tweaks to remove @chromium.org and Erik, will squash when we're happy with this.

@bnoordhuis
Copy link
Member

LGTM, one tiny nit.

rvagg added a commit that referenced this pull request Jan 7, 2015
PR-URL: #232
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@rvagg
Copy link
Member Author

rvagg commented Jan 7, 2015

landed in 53ba494

@rvagg rvagg closed this Jan 7, 2015
Trott added a commit to Trott/io.js that referenced this pull request Oct 29, 2021
The update-authors tool omits Chromium team members. This was a decision
made years ago. The idea was that these folks contributed to V8 not to
Node.js, as they typically ended up in our code-base via cherry-picked
commits from V8. Ref: nodejs#232

Now that there are over 3000 contributors identified in AUTHORS, some of
whom are bots that we run, I think it's time to undo this exception. If
we used someone else's code in a cherry-pick, congratulations to them,
they're authors. In particular, this will fix the omission of Yang
Guo who contributed extensively to Node.js outside of V8 contributions.
Trott added a commit to Trott/io.js that referenced this pull request Oct 29, 2021
The update-authors tool omits Chromium team members. This was a decision
made years ago. The idea was that these folks contributed to V8 not to
Node.js, as they typically ended up in our code-base via cherry-picked
commits from V8.
Ref: nodejs#232 (diff)

Now that there are over 3000 contributors identified in AUTHORS, some of
whom are bots that we run, I think it's time to undo this exception. If
we used someone else's code in a cherry-pick, congratulations to them,
they're authors. In particular, this will fix the omission of Yang
Guo who contributed extensively to Node.js outside of V8 contributions.
nodejs-github-bot pushed a commit that referenced this pull request Oct 31, 2021
The update-authors tool omits Chromium team members. This was a decision
made years ago. The idea was that these folks contributed to V8 not to
Node.js, as they typically ended up in our code-base via cherry-picked
commits from V8.
Ref: #232 (diff)

Now that there are over 3000 contributors identified in AUTHORS, some of
whom are bots that we run, I think it's time to undo this exception. If
we used someone else's code in a cherry-pick, congratulations to them,
they're authors. In particular, this will fix the omission of Yang
Guo who contributed extensively to Node.js outside of V8 contributions.

PR-URL: #40648
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Nov 6, 2021
The update-authors tool omits Chromium team members. This was a decision
made years ago. The idea was that these folks contributed to V8 not to
Node.js, as they typically ended up in our code-base via cherry-picked
commits from V8.
Ref: #232 (diff)

Now that there are over 3000 contributors identified in AUTHORS, some of
whom are bots that we run, I think it's time to undo this exception. If
we used someone else's code in a cherry-pick, congratulations to them,
they're authors. In particular, this will fix the omission of Yang
Guo who contributed extensively to Node.js outside of V8 contributions.

PR-URL: #40648
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
The update-authors tool omits Chromium team members. This was a decision
made years ago. The idea was that these folks contributed to V8 not to
Node.js, as they typically ended up in our code-base via cherry-picked
commits from V8.
Ref: #232 (diff)

Now that there are over 3000 contributors identified in AUTHORS, some of
whom are bots that we run, I think it's time to undo this exception. If
we used someone else's code in a cherry-pick, congratulations to them,
they're authors. In particular, this will fix the omission of Yang
Guo who contributed extensively to Node.js outside of V8 contributions.

PR-URL: #40648
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants