Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve test-gc-http-client-timeout #23184

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 18 additions & 20 deletions test/sequential/test-gc-http-client-timeout.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// just like test-gc-http-client.js,
// but with a timeout set

require('../common');
const common = require('../common');
const onGC = require('../common/ongc');

function serverHandler(req, res) {
Expand All @@ -15,46 +15,44 @@ function serverHandler(req, res) {
}

const http = require('http');
const todo = 550;
const todo = 300;
let done = 0;
let count = 0;
let countGC = 0;

console.log(`We should do ${todo} requests`);

const server = http.createServer(serverHandler);
server.listen(0, getall);
server.listen(0, common.mustCall(getall));

function getall() {
if (count >= todo)
return;

(function() {
function cb(res) {
res.resume();
done += 1;
}
const req = http.get({
hostname: 'localhost',
pathname: '/',
port: server.address().port
}, cb);

const req = http.get({
hostname: 'localhost',
pathname: '/',
port: server.address().port
}, cb);
req.setTimeout(10, function() {
console.log('timeout (expected)');
});

req.setTimeout(10, function() {
console.log('timeout (expected)');
});

count++;
onGC(req, { ongc });
})();
count++;
onGC(req, { ongc });

setImmediate(getall);
}

for (let i = 0; i < 10; i++)
getall();

function cb(res) {
res.resume();
done += 1;
}

function ongc() {
countGC++;
}
Expand Down