streams: refactor ReadableStream asyncIterator creation and a few fixes #23042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
stream
|
Can you explain in the commit message the reason for the refactor and what the fixes are? |
devsnek
force-pushed
the
refactor/readable-stream-async-iterator
branch
from
a0f83a8
to
ae8b7f8
Compare
|
@mcollina the lines i added to the test file are that |
|
@devsnek I specifically mean:
This seems a valid use case to test anyway. |
devsnek
force-pushed
the
refactor/readable-stream-async-iterator
branch
from
ae8b7f8
to
49eedb7
Compare
apapirovski
approved these changes
Sep 24, 2018
BridgeAR
approved these changes
Sep 24, 2018
BridgeAR
added
the
author ready
|
Re-run of failing node-test-commit-custom-suites-freestyle. |
Closes: nodejs#23041 - Rewrite `ReadableAsyncIterator` class into `ReadableStreamAsyncIteratorPrototype` which contains no constructor and inherits from `%AsyncIteratorPrototype%`. - Rewrite `AsyncIteratorRecord` into dumb function. PR-URL: nodejs#23042 Fixes: nodejs#23041 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
devsnek
force-pushed
the
refactor/readable-stream-async-iterator
branch
from
49eedb7
to
8bce9e8
Compare
|
landed in 8bce9e8 |
targos
pushed a commit
that referenced
this pull request
Oct 10, 2018
Closes: #23041 - Rewrite `ReadableAsyncIterator` class into `ReadableStreamAsyncIteratorPrototype` which contains no constructor and inherits from `%AsyncIteratorPrototype%`. - Rewrite `AsyncIteratorRecord` into dumb function. PR-URL: #23042 Fixes: #23041 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Oct 10, 2018
This was referenced Oct 11, 2018
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
Closes: #23041 - Rewrite `ReadableAsyncIterator` class into `ReadableStreamAsyncIteratorPrototype` which contains no constructor and inherits from `%AsyncIteratorPrototype%`. - Rewrite `AsyncIteratorRecord` into dumb function. PR-URL: #23042 Fixes: #23041 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #23041
@nodejs/streams
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes