Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: stop printing execution of lint-md command #22904

Closed
wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

The executed command is very verbose and removing that from the
output improves the overall experience.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

The executed command is very verbose and removing that from the
output improves the overall experience.
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Sep 17, 2018
@richardlau
Copy link
Member

For reference, here's what the output looks like:

before
[node-linter] Running shell script
+ NODE=node gmake lint-ci
Running JS linter...
Running C++ linter...
Total errors found: 0
Running Markdown linter on misc docs...
if [ -x /usr/home/iojs/build/workspace/node-linter/node ] && [ -e /usr/home/iojs/build/workspace/node-linter/node ]; then /usr/home/iojs/build/workspace/node-linter/node tools/lint-md.js -q -f lib/internal/readme.md benchmark/README.md test/README.md test/async-hooks/coverage.md test/common/README.md test/fixtures/0-dns/README.md test/fixtures/doc_inc_1.md test/fixtures/doc_inc_2.md test/fixtures/doc_with_yaml.md test/fixtures/order_of_end_tags_5873.md test/fixtures/sample_document.md tools/doc/README.md tools/icu/README.md README.md CODE_OF_CONDUCT.md CONTRIBUTING.md GOVERNANCE.md CHANGELOG.md BUILDING.md CPP_STYLE_GUIDE.md COLLABORATOR_GUIDE.md; elif [ -x `which node` ] && [ -e `which node` ] && [ `which node` ]; then `which node` tools/lint-md.js -q -f lib/internal/readme.md benchmark/README.md test/README.md test/async-hooks/coverage.md test/common/README.md test/fixtures/0-dns/README.md test/fixtures/doc_inc_1.md test/fixtures/doc_inc_2.md test/fixtures/doc_with_yaml.md test/fixtures/order_of_end_tags_5873.md test/fixtures/sample_document.md tools/doc/README.md tools/icu/README.md README.md CODE_OF_CONDUCT.md CONTRIBUTING.md GOVERNANCE.md CHANGELOG.md BUILDING.md CPP_STYLE_GUIDE.md COLLABORATOR_GUIDE.md; else echo "No available node, cannot run \"node tools/lint-md.js -q -f lib/internal/readme.md benchmark/README.md test/README.md test/async-hooks/coverage.md test/common/README.md test/fixtures/0-dns/README.md test/fixtures/doc_inc_1.md test/fixtures/doc_inc_2.md test/fixtures/doc_with_yaml.md test/fixtures/order_of_end_tags_5873.md test/fixtures/sample_document.md tools/doc/README.md tools/icu/README.md README.md CODE_OF_CONDUCT.md CONTRIBUTING.md GOVERNANCE.md CHANGELOG.md BUILDING.md CPP_STYLE_GUIDE.md COLLABORATOR_GUIDE.md\""; exit 1; fi;
touch tools/.miscmdlintstamp
Running Markdown linter on docs...
if [ -x /usr/home/iojs/build/workspace/node-linter/node ] && [ -e /usr/home/iojs/build/workspace/node-linter/node ]; then /usr/home/iojs/build/workspace/node-linter/node tools/lint-md.js -q -f doc/STYLE_GUIDE.md doc/api/addons.md doc/api/assert.md doc/api/async_hooks.md doc/api/buffer.md doc/api/child_process.md doc/api/cli.md doc/api/cluster.md doc/api/console.md doc/api/crypto.md doc/api/debugger.md doc/api/deprecations.md doc/api/dgram.md doc/api/dns.md doc/api/documentation.md doc/api/domain.md doc/api/errors.md doc/api/esm.md doc/api/events.md doc/api/fs.md doc/api/globals.md doc/api/http.md doc/api/http2.md doc/api/https.md doc/api/index.md doc/api/inspector.md doc/api/intl.md doc/api/modules.md doc/api/n-api.md doc/api/net.md doc/api/os.md doc/api/path.md doc/api/perf_hooks.md doc/api/process.md doc/api/punycode.md doc/api/querystring.md doc/api/readline.md doc/api/repl.md doc/api/stream.md doc/api/string_decoder.md doc/api/synopsis.md doc/api/timers.md doc/api/tls.md doc/api/tracing.md doc/api/tty.md doc/api/url.md doc/api/util.md doc/api/v8.md doc/api/vm.md doc/api/worker_threads.md doc/api/zlib.md doc/changelogs/CHANGELOG_ARCHIVE.md doc/changelogs/CHANGELOG_IOJS.md doc/changelogs/CHANGELOG_V010.md doc/changelogs/CHANGELOG_V012.md doc/changelogs/CHANGELOG_V10.md doc/changelogs/CHANGELOG_V4.md doc/changelogs/CHANGELOG_V5.md doc/changelogs/CHANGELOG_V6.md doc/changelogs/CHANGELOG_V7.md doc/changelogs/CHANGELOG_V8.md doc/changelogs/CHANGELOG_V9.md doc/guides/adding-new-napi-api.md doc/guides/backporting-to-release-lines.md doc/guides/building-node-with-ninja.md doc/guides/diagnostic-tooling-support-tiers.md doc/guides/maintaining-V8.md doc/guides/maintaining-npm.md doc/guides/maintaining-the-build-files.md doc/guides/node-postmortem-support.md doc/guides/using-internal-errors.md doc/guides/using-symbols.md doc/guides/writing-and-running-benchmarks.md doc/guides/writing-tests.md doc/offboarding.md doc/onboarding-extras.md doc/onboarding.md doc/releases.md; elif [ -x `which node` ] && [ -e `which node` ] && [ `which node` ]; then `which node` tools/lint-md.js -q -f doc/STYLE_GUIDE.md doc/api/addons.md doc/api/assert.md doc/api/async_hooks.md doc/api/buffer.md doc/api/child_process.md doc/api/cli.md doc/api/cluster.md doc/api/console.md doc/api/crypto.md doc/api/debugger.md doc/api/deprecations.md doc/api/dgram.md doc/api/dns.md doc/api/documentation.md doc/api/domain.md doc/api/errors.md doc/api/esm.md doc/api/events.md doc/api/fs.md doc/api/globals.md doc/api/http.md doc/api/http2.md doc/api/https.md doc/api/index.md doc/api/inspector.md doc/api/intl.md doc/api/modules.md doc/api/n-api.md doc/api/net.md doc/api/os.md doc/api/path.md doc/api/perf_hooks.md doc/api/process.md doc/api/punycode.md doc/api/querystring.md doc/api/readline.md doc/api/repl.md doc/api/stream.md doc/api/string_decoder.md doc/api/synopsis.md doc/api/timers.md doc/api/tls.md doc/api/tracing.md doc/api/tty.md doc/api/url.md doc/api/util.md doc/api/v8.md doc/api/vm.md doc/api/worker_threads.md doc/api/zlib.md doc/changelogs/CHANGELOG_ARCHIVE.md doc/changelogs/CHANGELOG_IOJS.md doc/changelogs/CHANGELOG_V010.md doc/changelogs/CHANGELOG_V012.md doc/changelogs/CHANGELOG_V10.md doc/changelogs/CHANGELOG_V4.md doc/changelogs/CHANGELOG_V5.md doc/changelogs/CHANGELOG_V6.md doc/changelogs/CHANGELOG_V7.md doc/changelogs/CHANGELOG_V8.md doc/changelogs/CHANGELOG_V9.md doc/guides/adding-new-napi-api.md doc/guides/backporting-to-release-lines.md doc/guides/building-node-with-ninja.md doc/guides/diagnostic-tooling-support-tiers.md doc/guides/maintaining-V8.md doc/guides/maintaining-npm.md doc/guides/maintaining-the-build-files.md doc/guides/node-postmortem-support.md doc/guides/using-internal-errors.md doc/guides/using-symbols.md doc/guides/writing-and-running-benchmarks.md doc/guides/writing-tests.md doc/offboarding.md doc/onboarding-extras.md doc/onboarding.md doc/releases.md; else echo "No available node, cannot run \"node tools/lint-md.js -q -f doc/STYLE_GUIDE.md doc/api/addons.md doc/api/assert.md doc/api/async_hooks.md doc/api/buffer.md doc/api/child_process.md doc/api/cli.md doc/api/cluster.md doc/api/console.md doc/api/crypto.md doc/api/debugger.md doc/api/deprecations.md doc/api/dgram.md doc/api/dns.md doc/api/documentation.md doc/api/domain.md doc/api/errors.md doc/api/esm.md doc/api/events.md doc/api/fs.md doc/api/globals.md doc/api/http.md doc/api/http2.md doc/api/https.md doc/api/index.md doc/api/inspector.md doc/api/intl.md doc/api/modules.md doc/api/n-api.md doc/api/net.md doc/api/os.md doc/api/path.md doc/api/perf_hooks.md doc/api/process.md doc/api/punycode.md doc/api/querystring.md doc/api/readline.md doc/api/repl.md doc/api/stream.md doc/api/string_decoder.md doc/api/synopsis.md doc/api/timers.md doc/api/tls.md doc/api/tracing.md doc/api/tty.md doc/api/url.md doc/api/util.md doc/api/v8.md doc/api/vm.md doc/api/worker_threads.md doc/api/zlib.md doc/changelogs/CHANGELOG_ARCHIVE.md doc/changelogs/CHANGELOG_IOJS.md doc/changelogs/CHANGELOG_V010.md doc/changelogs/CHANGELOG_V012.md doc/changelogs/CHANGELOG_V10.md doc/changelogs/CHANGELOG_V4.md doc/changelogs/CHANGELOG_V5.md doc/changelogs/CHANGELOG_V6.md doc/changelogs/CHANGELOG_V7.md doc/changelogs/CHANGELOG_V8.md doc/changelogs/CHANGELOG_V9.md doc/guides/adding-new-napi-api.md doc/guides/backporting-to-release-lines.md doc/guides/building-node-with-ninja.md doc/guides/diagnostic-tooling-support-tiers.md doc/guides/maintaining-V8.md doc/guides/maintaining-npm.md doc/guides/maintaining-the-build-files.md doc/guides/node-postmortem-support.md doc/guides/using-internal-errors.md doc/guides/using-symbols.md doc/guides/writing-and-running-benchmarks.md doc/guides/writing-tests.md doc/offboarding.md doc/onboarding-extras.md doc/onboarding.md doc/releases.md\""; exit 1; fi;
touch tools/.docmdlintstamp
cd tools/doc && if [ -x /usr/home/iojs/build/workspace/node-linter/node ] && [ -e /usr/home/iojs/build/workspace/node-linter/node ]; then /usr/home/iojs/build/workspace/node-linter/node /usr/home/iojs/build/workspace/node-linter/./deps/npm/bin/npm-cli.js ci; elif [ -x `which node` ] && [ -e `which node` ] && [ `which node` ]; then `which node` /usr/home/iojs/build/workspace/node-linter/./deps/npm/bin/npm-cli.js ci; else echo "No available node, cannot run \"node /usr/home/iojs/build/workspace/node-linter/./deps/npm/bin/npm-cli.js ci\""; exit 1; fi;
npm WARN prepare removing existing node_modules/ before installation
added 101 packages in 3.707s
rm -f -r test/addons/??_*/
[ -x node ] && node tools/doc/addon-verify.js || node tools/doc/addon-verify.js
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/01_function_arguments/test.js
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/02_callbacks/addon.cc
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/01_function_arguments/binding.gyp
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/02_callbacks/binding.gyp
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/01_function_arguments/addon.cc
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/03_object_factory/addon.cc
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/04_function_factory/test.js
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/03_object_factory/test.js
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/03_object_factory/binding.gyp
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/05_wrapping_c_objects/addon.cc
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/05_wrapping_c_objects/myobject.h
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/05_wrapping_c_objects/myobject.cc
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/05_wrapping_c_objects/test.js
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/07_passing_wrapped_objects_around/addon.cc
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/05_wrapping_c_objects/binding.gyp
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/07_passing_wrapped_objects_around/myobject.h
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/07_passing_wrapped_objects_around/myobject.cc
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/07_passing_wrapped_objects_around/test.js
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/07_passing_wrapped_objects_around/binding.gyp
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/06_factory_of_wrapped_objects/addon.cc
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/06_factory_of_wrapped_objects/myobject.h
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/06_factory_of_wrapped_objects/myobject.cc
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/06_factory_of_wrapped_objects/test.js
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/06_factory_of_wrapped_objects/binding.gyp
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/08_void_atexitcallback_args/addon.cc
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/08_void_atexitcallback_args/test.js
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/08_void_atexitcallback_args/binding.gyp
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/02_callbacks/test.js
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/04_function_factory/addon.cc
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/04_function_factory/binding.gyp
touch test/addons/.docbuildstamp
Running C++ linter on addon docs...
Total errors found: 0
after
[node-linter] Running shell script
+ NODE=node gmake lint-ci
Running JS linter...
Running C++ linter...
Total errors found: 0
Running Markdown linter on misc docs...
Running Markdown linter on docs...
cd tools/doc && if [ -x /usr/home/iojs/build/workspace/node-linter/node ] && [ -e /usr/home/iojs/build/workspace/node-linter/node ]; then /usr/home/iojs/build/workspace/node-linter/node /usr/home/iojs/build/workspace/node-linter/./deps/npm/bin/npm-cli.js ci; elif [ -x `which node` ] && [ -e `which node` ] && [ `which node` ]; then `which node` /usr/home/iojs/build/workspace/node-linter/./deps/npm/bin/npm-cli.js ci; else echo "No available node, cannot run \"node /usr/home/iojs/build/workspace/node-linter/./deps/npm/bin/npm-cli.js ci\""; exit 1; fi;
npm WARN prepare removing existing node_modules/ before installation
added 101 packages in 3.315s
rm -f -r test/addons/??_*/
[ -x node ] && node tools/doc/addon-verify.js || node tools/doc/addon-verify.js
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/01_function_arguments/addon.cc
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/01_function_arguments/test.js
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/02_callbacks/addon.cc
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/03_object_factory/addon.cc
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/03_object_factory/test.js
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/03_object_factory/binding.gyp
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/04_function_factory/addon.cc
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/04_function_factory/test.js
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/04_function_factory/binding.gyp
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/05_wrapping_c_objects/addon.cc
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/05_wrapping_c_objects/myobject.h
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/05_wrapping_c_objects/myobject.cc
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/05_wrapping_c_objects/test.js
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/05_wrapping_c_objects/binding.gyp
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/06_factory_of_wrapped_objects/addon.cc
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/06_factory_of_wrapped_objects/myobject.h
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/06_factory_of_wrapped_objects/myobject.cc
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/06_factory_of_wrapped_objects/test.js
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/06_factory_of_wrapped_objects/binding.gyp
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/07_passing_wrapped_objects_around/addon.cc
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/07_passing_wrapped_objects_around/myobject.h
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/07_passing_wrapped_objects_around/myobject.cc
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/07_passing_wrapped_objects_around/binding.gyp
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/07_passing_wrapped_objects_around/test.js
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/08_void_atexitcallback_args/addon.cc
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/08_void_atexitcallback_args/test.js
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/08_void_atexitcallback_args/binding.gyp
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/01_function_arguments/binding.gyp
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/02_callbacks/binding.gyp
Wrote /usr/home/iojs/build/workspace/node-linter/test/addons/02_callbacks/test.js
touch test/addons/.docbuildstamp
Running C++ linter on addon docs...
Total errors found: 0

The difference is more noticeable with word wrapping.

@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 18, 2018
@BridgeAR
Copy link
Member Author

Please +1 if you are fine with fast tracking this.

@BridgeAR
Copy link
Member Author

BridgeAR commented Sep 18, 2018

BridgeAR added a commit to BridgeAR/node that referenced this pull request Sep 19, 2018
The executed command is very verbose and removing that from the
output improves the overall experience.

PR-URL: nodejs#22904
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@BridgeAR
Copy link
Member Author

Landed in 92fd4fc 🎉

@BridgeAR BridgeAR deleted the reduce-command-output branch January 20, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants