Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: changing the hostname to an invalid name #2287

Closed

Conversation

thefourtheye
Copy link
Contributor

In my Ubuntu 14.04.2 LTS machine, it tries to resolve the name
'blah.blah' and it fails with ETIMEOUT instead of ENOTFOUND. This patch
changes the hostname to ..., an invalid name, so that it will fail
immediately.

cc @evanlucas

@thefourtheye thefourtheye added the test Issues and PRs related to the tests. label Aug 2, 2015
@bnoordhuis
Copy link
Member

Can you s/changing/change/ in the commit log? I have to admit I'm not super fond of the unrelated style changes.

I'm not sure if this change will work on all platforms. Unfortunately, I can't start a test run because the CI is acting up.

In my Ubuntu 14.04.2 LTS machine, it tries to resolve the name
'blah.blah' and it fails with ETIMEOUT instead of ENOTFOUND. This patch
changes the hostname to "...", an invalid name, so that it will fail
immediately.
@thefourtheye
Copy link
Contributor Author

@bnoordhuis Oh yeah, I updated the commit message. And regarding the CI, it will be fixed by Monday, I guess.

@thefourtheye
Copy link
Contributor Author

I tried a CI run earlier today and it was successful on all the other boxes, except Fedora 22 and Ubuntu 15.04_64. https://jenkins-iojs.nodesource.com/job/node-test-pull-request/28/

@thefourtheye
Copy link
Contributor Author

Possibly related: nodejs/node-v0.x-archive#5545

@evanlucas
Copy link
Contributor

LGTM if CI is happy

@evanlucas
Copy link
Contributor

Related: #2005

@thefourtheye
Copy link
Contributor Author

@evanlucas Yes, I feel that it is related. The name blah.blah is confusing different dns implementations I guess.

@thefourtheye
Copy link
Contributor Author

CI Run: node-test-commit/81

@thefourtheye
Copy link
Contributor Author

The test passes in all the machines. @bnoordhuis LGTY?

@bnoordhuis
Copy link
Member

LGTM

thefourtheye added a commit that referenced this pull request Aug 3, 2015
In my Ubuntu 14.04.2 LTS machine, it tries to resolve the name
'blah.blah' and it fails with ETIMEOUT instead of ENOTFOUND. This patch
changes the hostname to "...", an invalid name, so that it will fail
immediately.

PR-URL: #2287
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@thefourtheye
Copy link
Contributor Author

Thanks, landed at 64cf711.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants