Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: fix indentationLvl when exceeding max call stack size #22787

Closed
wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

The inspection indentation level was not always reset to it's former
value in case the maximum call stack size was exceeded.

It did not seem to be critical to add a test case for this as it's a pretty
special case that has no completely reliable output anyway (the stack
limit is not going to be identical on each run).
Please let me know if you feel I should add a test nevertheless.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

The inspection indentation level was not always reset to it's former
value in case the maximum call stack size was exceeded.
@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Sep 10, 2018
@BridgeAR
Copy link
Member Author

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 11, 2018
@BridgeAR
Copy link
Member Author

@nodejs/util PTAL

@BridgeAR
Copy link
Member Author

@BridgeAR
Copy link
Member Author

Landed in 08d983c

@BridgeAR BridgeAR closed this Sep 13, 2018
BridgeAR added a commit to BridgeAR/node that referenced this pull request Sep 13, 2018
The inspection indentation level was not always reset to it's former
value in case the maximum call stack size was exceeded.

PR-URL: nodejs#22787
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
Copy link
Member

targos commented Sep 14, 2018

Should this be backported to v10.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

targos pushed a commit to targos/node that referenced this pull request Sep 23, 2018
The inspection indentation level was not always reset to it's former
value in case the maximum call stack size was exceeded.

PR-URL: nodejs#22787
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 24, 2018
The inspection indentation level was not always reset to it's former
value in case the maximum call stack size was exceeded.

Backport-PR-URL: #23039
PR-URL: #22787
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos added backported-to-v10.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v10.x labels Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants