test: add test for internalConnect() when address type is IPv6

[yanivfriedensohn]

According to the latest coverage report, internalConnect() is uncovered when address type is IPv6 (https://coverage.nodejs.org/coverage-36696cfe8479f3fd/root/net.js.html#L887). This PR adds a test for internalConnect() when address type is IPv6.

I didn't add a test when address type is neither IPv4 nor IPv6 since this condition isn't reachable.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[addaleax]

The Travis CI failure seems related:

not ok 2356 sequential/test-net-connect-local-error
  ---
  duration_ms: 0.266
  severity: fail
  exitcode: 1
  stack: |-
    assert.js:338
        throw err;
        ^
    
    AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
    
      assert.ok(expectedErrorCodes.includes(err.code))
    
        at onError (/home/travis/build/nodejs/node/test/sequential/test-net-connect-local-error.js:28:10)
        at Socket.clientIPv6.on.common.mustCall (/home/travis/build/nodejs/node/test/sequential/test-net-connect-local-error.js:25:49)
        at Socket.<anonymous> (/home/travis/build/nodejs/node/test/common/index.js:464:15)
        at Socket.emit (events.js:182:13)
        at emitErrorNT (internal/streams/destroy.js:82:8)
        at emitErrorAndCloseNT (internal/streams/destroy.js:50:3)
        at process._tickCallback (internal/process/next_tick.js:63:19)
        at Function.Module.runMain (internal/modules/cjs/loader.js:745:11)
        at startup (internal/bootstrap/node.js:257:19)
        at bootstrapNodeJSCore (internal/bootstrap/node.js:634:3)

[refack]

Could this be a function declaration?

function onError(err, options) {

[yanivfriedensohn]

It's a named function expression.

[refack]

It's a style preference, function declaration are much more common in the test suite than named function expressions.

[yanivfriedensohn]

Thanks @addaleax, I added common.hasIPv6 before testing IPv6 and now the checks are passing.

[addaleax]

CI: https://ci.nodejs.org/job/node-test-pull-request/16650/ (edit: ✔️)

[refack]

Hello @yanivfriedensohn and אהלן. Thank you for your contribution 🥇
If you are not familiar with our review and landing process, it's covered in CONTRIBUTING.md. Any PR should stay open for at least 48 hours so that other contributors can review, comment, and familiarize with the change.

P.S. If you have any question you can also feel free to contact me directly.

[yanivfriedensohn]

Hi @refack and שלום. Following your comment I changed noError() to a function declaration.

[refack]

💯

[refack]

Thank you for following up.

[refack]

Fresh CI: https://ci.nodejs.org/job/node-test-pull-request/16686/

[addaleax]

Landed in e03f9c5, thanks for the PR! 🎉