Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix sorting in the vm.Module section #21931

Closed
wants to merge 1 commit into from
Closed

doc: fix sorting in the vm.Module section #21931

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Before:

1

After:

2

@nodejs-github-bot
Copy link
Collaborator

@vsemozhetbyt build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/331/pipeline

@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels Jul 22, 2018
@vsemozhetbyt
Copy link
Contributor Author

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 22, 2018
@vsemozhetbyt
Copy link
Contributor Author

Landed in 2ba3b57
Thank you for the reviews.

@vsemozhetbyt vsemozhetbyt deleted the doc-vm-sort branch July 22, 2018 14:44
vsemozhetbyt added a commit that referenced this pull request Jul 22, 2018
@vsemozhetbyt
doc: fix sorting in the vm.Module section
2ba3b57 
PR-URL: #21931
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this pull request Jul 24, 2018
@vsemozhetbyt @targos
doc: fix sorting in the vm.Module section
5e562fd 
PR-URL: #21931
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos targos mentioned this pull request Jul 31, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsemozhetbyt @nodejs-github-bot @benjamingr @lpinca