Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8: cherry-pick JitCodeEvent patch from upstream #2075

Merged
merged 1 commit into from
Jun 29, 2015

Conversation

bnoordhuis
Copy link
Member

Original commit log follows:

Meaningful name for builtins in JitCodeEvent API.

Report builtins by name (e.g. "Builtin:ArgumentsAdaptorTrampoline")
instead of labeling everything "Builtin:A builtin from the snapshot"

Review URL: https://codereview.chromium.org/1216833002

R=@trevnorris?

CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/92/

Original commit log follows:

    Meaningful name for builtins in JitCodeEvent API.

    Report builtins by name (e.g. "Builtin:ArgumentsAdaptorTrampoline")
    instead of labeling everything "Builtin:A builtin from the snapshot"

    Review URL: https://codereview.chromium.org/1216833002

PR-URL: nodejs#2075
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@trevnorris
Copy link
Contributor

LGTM

@bnoordhuis bnoordhuis closed this Jun 29, 2015
@bnoordhuis bnoordhuis deleted the v8-jitcodeevent-patch branch June 29, 2015 15:11
@bnoordhuis bnoordhuis merged commit 1a51f00 into nodejs:master Jun 29, 2015
@rvagg
Copy link
Member

rvagg commented Jun 29, 2015

this is for debugging I imagine? it'd be good to get a justification with these cherry-picks

@bnoordhuis
Copy link
Member Author

@rvagg It makes output from the profiler a little more useful.

@rvagg rvagg mentioned this pull request Jun 30, 2015
mscdex pushed a commit to mscdex/io.js that referenced this pull request Jul 9, 2015
Original commit log follows:

    Meaningful name for builtins in JitCodeEvent API.

    Report builtins by name (e.g. "Builtin:ArgumentsAdaptorTrampoline")
    instead of labeling everything "Builtin:A builtin from the snapshot"

    Review URL: https://codereview.chromium.org/1216833002

PR-URL: nodejs#2075
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants