Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9.x] net: handle allowHalfOpen before calling super ctor #19772

Closed
wants to merge 3 commits into from
Closed

[v9.x] net: handle allowHalfOpen before calling super ctor #19772

wants to merge 3 commits into from

Commits on Apr 3, 2018

  1. Revert "stream: make Duplex inherits from DuplexBase" 

    This reverts commit 152c931.
    @lpinca
    lpinca committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    588bcf0 View commit details
    Browse the repository at this point in the history

  2. Revert "net: do not inherit the no-half-open enforcer" 

    This reverts commit 5b12d3a.
    @lpinca
    lpinca committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    fb938e4 View commit details
    Browse the repository at this point in the history

  3. net: handle allowHalfOpen before calling super ctor 

    If the `allowHalfOpen` option is not provided, use its default value
before calling the `Duplex` constructor. This allows the no-half-open
enforcer to be properly added.

Fixes: nodejs#19764
    @lpinca
    lpinca committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    36b5e01 View commit details
    Browse the repository at this point in the history