Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove ES6/ECMAScript 2015 from buffer.md #19685

Closed
wants to merge 2 commits into from
Closed

doc: remove ES6/ECMAScript 2015 from buffer.md #19685

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 29, 2018

As the introduction of ES6 features recedes further into the past, it is
less and less relevant (and more and more distracting) to cite it in
documentation text. Remove mention in buffer.md.

Checklist

@Trott
doc: remove ES6/ECMAScript 2015 from buffer.md
9f8b3af 
As the introduction of ES6 features recedes further into the past, it is
less and less relevant (and more and more distracting) to cite it in
documentation text. Remove mention in buffer.md.
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Mar 29, 2018
@Trott
Copy link
Member Author

Trott commented Mar 29, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/359/

TimothyGu
TimothyGu approved these changes Mar 29, 2018
View reviewed changes
doc/api/buffer.md Outdated
@@ -277,8 +275,7 @@ function:

## Buffers and ES6 iteration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another instance of ES6.

@vsemozhetbyt vsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 29, 2018
@Trott
Copy link
Member Author

Trott commented Mar 29, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/360/

@Trott
Copy link
Member Author

Trott commented Mar 31, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/371/

@trivikr
Copy link
Member

trivikr commented Mar 31, 2018

Landed in a2ffdc9

@trivikr trivikr closed this Mar 31, 2018
trivikr pushed a commit that referenced this pull request Mar 31, 2018
@Trott @trivikr
doc: remove ES6/ECMAScript 2015 from buffer.md
a2ffdc9 
As the introduction of ES6 features recedes further into the past, it
is less and less relevant (and more and more distracting) to cite it in
documentation text. Remove mention in buffer.md.

PR-URL: #19685
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Apr 2, 2018
@Trott @targos
doc: remove ES6/ECMAScript 2015 from buffer.md
c8fa8f1 
As the introduction of ES6 features recedes further into the past, it
is less and less relevant (and more and more distracting) to cite it in
documentation text. Remove mention in buffer.md.

PR-URL: #19685
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Apr 4, 2018
Merged
@ChALkeR ChALkeR mentioned this pull request Jun 29, 2018
Closed
2 tasks
MylesBorins pushed a commit that referenced this pull request Jun 29, 2018
@Trott @MylesBorins
doc: remove ES6/ECMAScript 2015 from buffer.md
b215928 
As the introduction of ES6 features recedes further into the past, it
is less and less relevant (and more and more distracting) to cite it in
documentation text. Remove mention in buffer.md.

Backport-PR-URL: #21590
PR-URL: #19685
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 9, 2018
@Trott @MylesBorins
doc: remove ES6/ECMAScript 2015 from buffer.md
71a8f6c 
As the introduction of ES6 features recedes further into the past, it
is less and less relevant (and more and more distracting) to cite it in
documentation text. Remove mention in buffer.md.

Backport-PR-URL: #21590
PR-URL: #19685
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 9, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jul 10, 2018
@Trott @MylesBorins
doc: remove ES6/ECMAScript 2015 from buffer.md
b2f26e6 
As the introduction of ES6 features recedes further into the past, it
is less and less relevant (and more and more distracting) to cite it in
documentation text. Remove mention in buffer.md.

Backport-PR-URL: #21590
PR-URL: #19685
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@Trott @rvagg
doc: remove ES6/ECMAScript 2015 from buffer.md
cf0577e 
As the introduction of ES6 features recedes further into the past, it
is less and less relevant (and more and more distracting) to cite it in
documentation text. Remove mention in buffer.md.

Backport-PR-URL: #21590
PR-URL: #19685
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@Trott @rvagg
doc: remove ES6/ECMAScript 2015 from buffer.md
3ad5e30 
As the introduction of ES6 features recedes further into the past, it
is less and less relevant (and more and more distracting) to cite it in
documentation text. Remove mention in buffer.md.

Backport-PR-URL: #21590
PR-URL: #19685
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott Trott deleted the es6less branch January 13, 2022 22:49
abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this pull request May 5, 2024
@Trott @ChALkeR
doc: remove ES6/ECMAScript 2015 from buffer.md
0410b5b 
As the introduction of ES6 features recedes further into the past, it
is less and less relevant (and more and more distracting) to cite it in
documentation text. Remove mention in buffer.md.

PR-URL: nodejs/node#19685
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @trivikr @lpinca @TimothyGu @cjihrig @vsemozhetbyt @MylesBorins @nodejs-github-bot