Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9.x] backport 18656 + 19002 #19185

Closed
wants to merge 6 commits into from
Closed

[v9.x] backport 18656 + 19002 #19185

wants to merge 6 commits into from

Commits on Mar 6, 2018

  1. src: handle exceptions in env->SetImmediates 

    PR-URL: nodejs#18297
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @jasnell @addaleax
    jasnell authored and addaleax committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    8ff43ad View commit details
    Browse the repository at this point in the history

  2. src: prevent persistent handle resource leaks 

    Replace v8::Persistent with node::Persistent, a specialization that
resets the persistent handle on destruction.  Prevents accidental
resource leaks when forgetting to call .Reset() manually.

I'm fairly confident this commit fixes a number of resource leaks that
have gone undiagnosed so far.

PR-URL: nodejs#18656
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @bnoordhuis @addaleax
    bnoordhuis authored and addaleax committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    9f426f7 View commit details
    Browse the repository at this point in the history

  3. [squash] v9.x-specific fixups

    @addaleax
    addaleax committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    097009a View commit details
    Browse the repository at this point in the history

  4. src: remove unnecessary Reset() calls 

    The previous commit made persistent handles auto-reset on destruction.
This commit removes the Reset() calls that are now no longer necessary.

PR-URL: nodejs#18656
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @bnoordhuis @addaleax
    bnoordhuis authored and addaleax committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    3de8e57 View commit details
    Browse the repository at this point in the history

  5. src: don't touch js object in Http2Session dtor 

    Don't try to update the internal field pointer of the JS object in the
destructor.

The garbage collector invokes the destructor when the object is
collected and is not necessarily in a valid state anymore.

PR-URL: nodejs#18656
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @bnoordhuis @addaleax
    bnoordhuis authored and addaleax committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    8c363cd View commit details
    Browse the repository at this point in the history

  6. http2: no stream destroy while its data is on the wire 

    This fixes a crash that occurred when a `Http2Stream` write
is completed after it is already destroyed.

Instead, don’t destroy the stream in that case and wait for
GC to take over.

PR-URL: nodejs#19002
Fixes: nodejs#18973
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    @addaleax
    addaleax committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    8827b71 View commit details
    Browse the repository at this point in the history