Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 6.4.388.44 #18687

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 6.4.388.44 #18687

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Feb 9, 2018
@MylesBorins
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/13073/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1211/

@MylesBorins
Copy link
Contributor Author

One more CI: https://ci.nodejs.org/job/node-test-pull-request/13074/

@MylesBorins
Copy link
Contributor Author

yet again CI https://ci.nodejs.org/job/node-test-pull-request/13096/

@MylesBorins
Copy link
Contributor Author

One more CI... boy has it been weird this weekend

https://ci.nodejs.org/job/node-test-pull-request/13113/

fhinkel
fhinkel approved these changes Feb 12, 2018
View reviewed changes
Copy link
Member

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! :)

@MylesBorins
Copy link
Contributor Author

rebased against master... one more run

https://ci.nodejs.org/job/node-test-pull-request/13127/

@MylesBorins
Copy link
Contributor Author

openssl link failure is an infra flake. re running the ppc test

https://ci.nodejs.org/job/node-test-commit-plinux/15343/

@MylesBorins
Copy link
Contributor Author

MylesBorins commented Feb 13, 2018 •
edited
Loading

ppc test is green

landed in b6000d8

MylesBorins added a commit that referenced this pull request Feb 13, 2018
@MylesBorins
deps: patch V8 to 6.4.388.44
b6000d8 
PR-URL: #18687
Refs: v8/v8@6.4.388.42...6.4.388.44
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@MylesBorins @MayaLekova
deps: patch V8 to 6.4.388.44
bae9c10 
PR-URL: nodejs#18687
Refs: v8/v8@6.4.388.42...6.4.388.44
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This was referenced Mar 7, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@targos targos targos approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@ofrobots ofrobots Awaiting requested review from ofrobots

Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MylesBorins @fhinkel @targos @BridgeAR @nodejs-github-bot