Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Use common module API on child exec #17751

Closed
wants to merge 1 commit into from
Closed

test: Use common module API on child exec #17751

wants to merge 1 commit into from

Conversation

sreepurnajasti
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 19, 2017
@danbev
Copy link
Contributor

danbev commented Dec 19, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/

cjihrig
cjihrig approved these changes Dec 19, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a suggestion.

test/parallel/test-child-process-exec-stdout-stderr-data-string.js Outdated
assert(stdoutCalls > 0);
assert(stderrCalls > 0);
});
exec('fhqwhgads').stderr.on('data', common.mustCall((data) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use common.mustCallAtLeast() here too, just to be safe because it's dealing with data events.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjihrig Done!! Please have a look.

lpinca
lpinca approved these changes Dec 20, 2017
View reviewed changes
test/parallel/test-child-process-exec-stdout-stderr-data-string.js Outdated
assert.strictEqual(typeof data, 'string');
stderrCalls += 1;
});
exec(command).stdout.on('data', common.mustCallAtLeast((data) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we can remove the data argument.

Copy link
Contributor Author

@sreepurnajasti sreepurnajasti Dec 21, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lpinca Thanks. Done!!

@maclover7
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/12256/

BridgeAR
BridgeAR approved these changes Dec 22, 2017
View reviewed changes
test/parallel/test-child-process-exec-stdout-stderr-data-string.js Outdated
stderrCalls += 1;
});
exec(command).stdout.on('data', common.mustCallAtLeast(() => {
}));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the callback is actually optional.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BridgeAR I missed it. Its done. Thanks!!

@maclover7
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/12261/

@maclover7
Copy link
Contributor

Landing...

@maclover7 maclover7 self-assigned this Dec 24, 2017
maclover7 pushed a commit to maclover7/node that referenced this pull request Dec 24, 2017
@sreepurnajasti @maclover7
test: use common module API in test-child-process-exec-stdout-stderr-…
4d74b52 
…data-string

PR-URL: nodejs#17751
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@maclover7
Copy link
Contributor

Thank you for your contribution, landed in 4d74b52.
❤️ 💚 💙 💛 💜

@maclover7 maclover7 closed this Dec 24, 2017
@sreepurnajasti sreepurnajasti deleted the commonAPI branch December 27, 2017 06:35
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@sreepurnajasti @MylesBorins
test: use common module API in test-child-process-exec-stdout-stderr-…
3be3176 
…data-string

PR-URL: #17751
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@sreepurnajasti @MylesBorins
test: use common module API in test-child-process-exec-stdout-stderr-…
fd9f8ab 
…data-string

PR-URL: #17751
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@sreepurnajasti @MylesBorins
test: use common module API in test-child-process-exec-stdout-stderr-…
ded097a 
…data-string

PR-URL: #17751
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@sreepurnajasti @gibfahn
test: use common module API in test-child-process-exec-stdout-stderr-…
377a23a 
…data-string

PR-URL: #17751
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@sreepurnajasti @gibfahn
test: use common module API in test-child-process-exec-stdout-stderr-…
ae28013 
…data-string

PR-URL: #17751
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@sreepurnajasti @gibfahn
test: use common module API in test-child-process-exec-stdout-stderr-…
59aa505 
…data-string

PR-URL: #17751
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@sreepurnajasti @MylesBorins
test: use common module API in test-child-process-exec-stdout-stderr-…
78e0cb9 
…data-string

PR-URL: #17751
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@sreepurnajasti @MylesBorins
test: use common module API in test-child-process-exec-stdout-stderr-…
87baf4d 
…data-string

PR-URL: #17751
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@sreepurnajasti @MylesBorins
test: use common module API in test-child-process-exec-stdout-stderr-…
5314754 
…data-string

PR-URL: #17751
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@maclover7 maclover7 maclover7 approved these changes

@hiroppy hiroppy hiroppy approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

@maclover7 maclover7

Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@sreepurnajasti @danbev @maclover7 @jasnell @lpinca @cjihrig @hiroppy @BridgeAR @gibfahn @nodejs-github-bot