-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: add openssl-system-ca-path configure option #16790
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -297,13 +297,24 @@ | |
'<(SHARED_INTERMEDIATE_DIR)/node_javascript.cc', | ||
], | ||
|
||
'variables': { | ||
'openssl_system_ca_path%': '', | ||
}, | ||
|
||
'defines': [ | ||
'NODE_ARCH="<(target_arch)"', | ||
'NODE_PLATFORM="<(OS)"', | ||
'NODE_WANT_INTERNALS=1', | ||
# Warn when using deprecated V8 APIs. | ||
'V8_DEPRECATION_WARNINGS=1', | ||
'NODE_OPENSSL_SYSTEM_CERT_PATH="<(openssl_system_ca_path)"', | ||
], | ||
|
||
'direct_dependent_settings': { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This section should really not be required but is because the moment as src/node_crypto.cc is included in the sources for the cctest target (though not explicitly but through node.gypi). I'm working on a PR for this so that no sources other than the ones listed in cctest are compiled. |
||
'defines': [ | ||
'NODE_OPENSSL_SYSTEM_CERT_PATH="<(openssl_system_ca_path)"', | ||
], | ||
}, | ||
}, | ||
{ | ||
'target_name': 'mkssldef', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use
action='store'
(single quotes) here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problems, I'll update that. Thanks