stream: complete migration to internal/errors #16589
Closed
+77
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
errors
|
@nodejs/tsc this needs expedite, as we need it for the 9 release. I'm sorry, but I caught these just now. |
addaleax
approved these changes
Oct 29, 2017
|
I think @jasnell wanted to build the binaries ~ now? I’m okay with expediting but maybe we have the time for a CITGM run as well? |
mcollina
added
the
semver-major
jasnell
approved these changes
Oct 29, 2017
lib/_stream_readable.js
Outdated
| @@ -284,7 +284,7 @@ function chunkInvalid(state, chunk) { | |||
| typeof chunk !== 'string' && | |||
| chunk !== undefined && | |||
| !state.objectMode) { | |||
| er = new TypeError('Invalid non-string/buffer chunk'); | |||
| er = new errors.TypeError('ERR_STREAM_INVALID_CHUNK'); | |||
There was a problem hiding this comment.
Should probably just use ERR_INVALID_ARG_TYPE here
lib/_stream_writable.js
Outdated
| } else if (typeof chunk !== 'string' && | ||
| chunk !== undefined && | ||
| !state.objectMode) { | ||
| er = new TypeError('Invalid non-string/buffer chunk'); | ||
| er = new errors.TypeError('ERR_STREAM_INVALID_CHUNK'); |
joyeecheung
approved these changes
Oct 29, 2017
| <a id="ERR_STREAM_CANNOT_PIPE"></a> | ||
| ### ERR_STREAM_CANNOT_PIPE | ||
|
|
||
| Used when an attempt is made to call [`stream.pipe()`][] on a |
There was a problem hiding this comment.
Missing link definitions, so are Writable and stream.write()
Complete the migration to the new error system of _stream_readable and _stream_writable. Adds the corresponding documentation.
mcollina
force-pushed
the
stream-new-errors
branch
from
d464d69
to
2651f29
Compare
|
I'll be doing one final pull from master this afternoon and will be kicking off the release build later on today. |
|
Landed as 6e86a66 |
mcollina
added a commit
that referenced
this pull request
Oct 29, 2017
Complete the migration to the new error system of _stream_readable and _stream_writable. Adds the corresponding documentation. PR-URL: #16589 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2 tasks
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
Complete the migration to the new error system of _stream_readable and _stream_writable. Adds the corresponding documentation. PR-URL: nodejs/node#16589 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
Complete the migration to the new error system of _stream_readable and _stream_writable. Adds the corresponding documentation. PR-URL: nodejs/node#16589 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
Complete the migration to the new error system of _stream_readable and _stream_writable. Adds the corresponding documentation. PR-URL: nodejs/node#16589 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
stream