Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix NODE_DEPRECATED macro with old compilers #1626

Merged
merged 1 commit into from
May 5, 2015
Merged

src: fix NODE_DEPRECATED macro with old compilers #1626

merged 1 commit into from
May 5, 2015

Commits on May 5, 2015

  1. src: fix NODE_DEPRECATED macro with old compilers 

    The `__attribute__((deprecated("warning")))` macro didn't exist until
gcc 4.5 and clang 2.9.

While io.js does not build with compilers that old, add-ons do.  Let's
make src/node.h compatible with such compilers, it's a public header.

PR-URL: nodejs#1626
Refs: nodejs#1619
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    @bnoordhuis
    bnoordhuis committed May 5, 2015
    3 Configuration menu
    Copy the full SHA
    b712af7 View commit details
    Browse the repository at this point in the history