Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: clean up string concatenation #15820

Closed
wants to merge 2 commits into from
Closed

test: clean up string concatenation #15820

wants to merge 2 commits into from

Conversation

agilbert
Copy link
Contributor

@agilbert agilbert commented Oct 6, 2017

This commit replaces string concatenation with template literals.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

agilbert added 2 commits October 6, 2017 09:31
test: clean up string concat in dlopen-ping-pong
c46913e 
replace string concatenation with template literals.
test: remove extra whitespace
105de8e
@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. test Issues and PRs related to the tests. labels Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@gibfahn
Copy link
Member

gibfahn commented Oct 9, 2017

CI: https://ci.nodejs.org/job/node-test-commit/12936/

gireeshpunathil pushed a commit that referenced this pull request Oct 11, 2017
@gireeshpunathil
test: clean up string concat in dlopen-ping-pong
16ed116 
replace string concatenation with template literals.

PR-URL: #15820
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@gireeshpunathil
Copy link
Member

Landed in 16ed116
Thank you for the contribution!

addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@addaleax
test: clean up string concat in dlopen-ping-pong
434d410 
replace string concatenation with template literals.

PR-URL: nodejs/node#15820
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@targos
Copy link
Member

targos commented Oct 18, 2017

Marking dont-land-on- because this test was added in #12794 which is semver-major.

@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmg rmg rmg approved these changes

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
addons Issues and PRs related to native addons. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.