Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace common.fixturesDir with usage of the common.fixtures #15803

Closed
wants to merge 1 commit into from
Closed

test: replace common.fixturesDir with usage of the common.fixtures #15803

wants to merge 1 commit into from

Conversation

aniwng
Copy link
Contributor

@aniwng aniwng commented Oct 6, 2017

module

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@aniwng aniwng closed this Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@lance lance mentioned this pull request Oct 7, 2017
Closed
22 tasks
@gibfahn
Copy link
Member

gibfahn commented Oct 7, 2017

@aniwng did you mean to close this? If not we should get this landed!

Code changes LGTM.

@targos
Copy link
Member

targos commented Oct 7, 2017

I think it was opened twice by mistake. See #15813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aniwng @gibfahn @targos @Trott @nodejs-github-bot