Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix outdated code sample in n-api.md #15581

Closed
wants to merge 1 commit into from

Conversation

rebornix
Copy link
Contributor

Code sample of napi_create_object and napi_property_descriptor were
not updated to latest API. Ran into this problem while migrating NAN projects to N-API.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

code samples of napi_create_object and napi_property_descriptor were
not updated to latest API.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. dont-land-on-v4.x node-api Issues and PRs related to the Node-API. labels Sep 24, 2017
jasnell pushed a commit that referenced this pull request Sep 26, 2017
code samples of napi_create_object and napi_property_descriptor were
not updated to latest API.

PR-URL: #15581
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Sep 26, 2017
code samples of napi_create_object and napi_property_descriptor were
not updated to latest API.

PR-URL: #15581
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Sep 26, 2017

Landed in 0a050e9

@jasnell jasnell closed this Sep 26, 2017
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
code samples of napi_create_object and napi_property_descriptor were
not updated to latest API.

PR-URL: #15581
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 30, 2017
code samples of napi_create_object and napi_property_descriptor were
not updated to latest API.

PR-URL: nodejs/node#15581
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 3, 2017
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018
code samples of napi_create_object and napi_property_descriptor were
not updated to latest API.

PR-URL: nodejs#15581
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
code samples of napi_create_object and napi_property_descriptor were
not updated to latest API.

Backport-PR-URL: #19447
PR-URL: #15581
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants