Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: prevent displaying empty version picker #15420

Closed
wants to merge 1 commit into from
Closed

doc: prevent displaying empty version picker #15420

wants to merge 1 commit into from

Conversation

chris--young
Copy link

This will prevent an empty drop down from being displayed when pages do not have multiple version to choose from

Fixes: #15396

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc, tools

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Sep 14, 2017
jasnell
jasnell approved these changes Sep 15, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@refack
Copy link
Contributor

refack commented Sep 15, 2017

@chris--young Thanks!
If it's not too much work, could you run the tool pre and post PR and upload a sample page (e.g. n-api.html) as a gist?

@chris--young
Copy link
Author

chris--young commented Sep 15, 2017 •
edited
Loading

@refack for sure

pre
post

the difference is around line 95

@BridgeAR
Copy link
Member

@chris--young thanks a lot!

Landed in 2b7b9f2

@BridgeAR BridgeAR closed this Sep 19, 2017
BridgeAR pushed a commit that referenced this pull request Sep 19, 2017
@BridgeAR
doc: prevent displaying empty version picker
2b7b9f2 
PR-URL: #15420
Fixes: #15396
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell pushed a commit that referenced this pull request Sep 20, 2017
@jasnell
doc: prevent displaying empty version picker
f0e411d 
PR-URL: #15420
Fixes: #15396
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@refack refack mentioned this pull request Sep 20, 2017
Closed
3 tasks
@jasnell jasnell mentioned this pull request Sep 20, 2017
Merged
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
doc: prevent displaying empty version picker
93616ed 
PR-URL: nodejs/node#15420
Fixes: nodejs/node#15396
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
chris--young pushed a commit to chris--young/node that referenced this pull request Sep 29, 2017
doc: prevent displaying empty version picker
7cd60e0 
PR-URL: nodejs#15420
Fixes: nodejs#15396
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
@MylesBorins
doc: prevent displaying empty version picker
a13ac69 
Backport-PR-URL: #15670
PR-URL: #15420
Fixes: #15396
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Sep 29, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@addaleax
doc: prevent displaying empty version picker
0c76f93 
PR-URL: nodejs/node#15420
Fixes: nodejs/node#15396
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@jasnell jasnell jasnell approved these changes

@evanlucas evanlucas evanlucas approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: empty version picker on some pages
7 participants
@chris--young @refack @BridgeAR @jasnell @evanlucas @MylesBorins @nodejs-github-bot