Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-fs-readfile-unlink #15173

Closed
wants to merge 1 commit into from
Closed

test: refactor test-fs-readfile-unlink #15173

wants to merge 1 commit into from

Commits on Sep 5, 2017

  1. test: refactor test-fs-readfile-unlink 

    * Use tmp directory instead of mutating the fixtures directory.
* Add comment explaining that the unlinkSync() at the end of the test is
  part of the test. Otherwise it may be tempting to remove it as
  unnecessary tmp directory cleanup.
    @Trott
    Trott committed Sep 5, 2017
    Configuration menu
    Copy the full SHA
    5ebdbc1 View commit details
    Browse the repository at this point in the history