[v6.x backport] net: fix abort on bad address input #14390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, add tests to ensure they will always return this, and to confirm they return this when these doc changes are back-ported to earlier release lines. PR-URL: nodejs#13553 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#13989 Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: nodejs#14035 Refs: nodejs#14015 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The v8 and test-hash-seed targets cannot be run in parallel because they need different copies of the deps/v8 directory. Ref: nodejs#14004 (comment) PR-URL: nodejs#14219 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
* Take RegExp creation out of cycles. * Use test(), not match() in boolean context. * Remove redundant RegExp parts. Backport-PR-URL: nodejs#14348 PR-URL: nodejs#13536 Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: nodejs#13726 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
approved these changes
Jul 20, 2017
XadillaX
approved these changes
Jul 20, 2017
refack
approved these changes
Jul 20, 2017
|
ping @nodejs/lts ... this one should definitely be run through citgm before landing. |
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/917/ The assumption is that the process would segfault without this protection. |
MylesBorins
force-pushed
the
v6.x-staging
branch
from
d29fd52
to
97f5806
Compare
|
Going to hold off on landing this one in v6.11.2 We can begin testing it after that release goes out |
jasnell
approved these changes
Jul 21, 2017
MylesBorins
force-pushed
the
v6.x-staging
branch
from
7b8fcf8
to
f4691bb
Compare
MylesBorins
force-pushed
the
v6.x-staging
branch
6 times, most recently
from
f9419c2
to
403c465
Compare
MylesBorins
force-pushed
the
v6.x-staging
branch
2 times, most recently
from
aaf4e13
to
31f572c
Compare
|
landed in 792acc1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport to 6.x: #13726
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
net