Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v6.x-staging) doc: remove leftover WHATWG url.format section #14351

Closed
wants to merge 1 commit into from

Conversation

silverwind
Copy link
Contributor

The backport in #13054 contained a leftover section from the WHATWG url.format, in addition to the existing url.format. This removes this section.

Ref: #13054 (comment). Seems to only affect v6.x-staging, v6.x does not have this issue.

cc: @gibfahn

The backport in nodejs#13054 contained a
leftover section from the WHATWG url.format, in addition to the existing
url.format. This removes this section.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. v6.x labels Jul 18, 2017
@MylesBorins
Copy link
Contributor

MylesBorins commented Jul 18, 2017

landed in fcb27fa

MylesBorins pushed a commit that referenced this pull request Jul 18, 2017
The backport in #13054 contained a
leftover section from the WHATWG url.format, in addition to the existing
url.format. This removes this section.

PR-URL: #14351
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@silverwind silverwind deleted the pr-13054-fix branch July 18, 2017 18:58
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants