Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-cluster-basic #13905

Closed
wants to merge 1 commit into from
Closed

test: refactor test-cluster-basic #13905

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 25, 2017

  • Use common.mustNotCall() to check that callback is not invoked.
  • Add space per test writing guide.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test cluster

@Trott
test: refactor test-cluster-basic
85bbd41 
* Use common.mustNotCall() to check that callback is not invoked.
* Add space per test writing guide.
@Trott Trott added cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests. labels Jun 25, 2017
@Trott
Copy link
Member Author

Trott commented Jun 25, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8821/

@Trott
Copy link
Member Author

Trott commented Jun 29, 2017

Landed in 3b727aa

@Trott Trott closed this Jun 29, 2017
Trott added a commit to Trott/io.js that referenced this pull request Jun 29, 2017
@Trott
test: refactor test-cluster-basic
3b727aa 
* Use common.mustNotCall() to check that callback is not invoked.
* Add space per test writing guide.

PR-URL: nodejs#13905
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jun 29, 2017
@Trott @addaleax
test: refactor test-cluster-basic
3dddaab 
* Use common.mustNotCall() to check that callback is not invoked.
* Add space per test writing guide.

PR-URL: #13905
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax mentioned this pull request Jun 29, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 11, 2017
@Trott @addaleax
test: refactor test-cluster-basic
1bcea3a 
* Use common.mustNotCall() to check that callback is not invoked.
* Add space per test writing guide.

PR-URL: #13905
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@Trott @addaleax
test: refactor test-cluster-basic
b43547a 
* Use common.mustNotCall() to check that callback is not invoked.
* Add space per test writing guide.

PR-URL: #13905
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
@Trott @MylesBorins
test: refactor test-cluster-basic
df50e01 
* Use common.mustNotCall() to check that callback is not invoked.
* Add space per test writing guide.

PR-URL: #13905
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 15, 2017
@Trott @MylesBorins
test: refactor test-cluster-basic
5865268 
* Use common.mustNotCall() to check that callback is not invoked.
* Add space per test writing guide.

PR-URL: #13905
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@Trott @MylesBorins
test: refactor test-cluster-basic
74945dd 
* Use common.mustNotCall() to check that callback is not invoked.
* Add space per test writing guide.

PR-URL: #13905
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2017
Merged
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the refactor-test-cluster-basic branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@hiroppy hiroppy hiroppy approved these changes

Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @jasnell @lpinca @cjihrig @hiroppy @MylesBorins