Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: unify ERR_FALSY_VALUE_REJECTION description #13869

Closed
wants to merge 1 commit into from
Closed

doc: unify ERR_FALSY_VALUE_REJECTION description #13869

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

Refs: #13604
Refs: #13627

Checklist
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Jun 22, 2017
@tniessen tniessen self-assigned this Jun 22, 2017
@tniessen
Copy link
Member Author

Landed in 23b3bbf.

@tniessen tniessen closed this Jun 28, 2017
tniessen added a commit that referenced this pull request Jun 28, 2017
@tniessen
doc: unify ERR_FALSY_VALUE_REJECTION description
23b3bbf 
PR-URL: #13869
Refs: #13604
Refs: #13627
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Jun 29, 2017
@tniessen @addaleax
doc: unify ERR_FALSY_VALUE_REJECTION description
6657c4c 
PR-URL: #13869
Refs: #13604
Refs: #13627
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@addaleax addaleax mentioned this pull request Jun 29, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 11, 2017
@tniessen @addaleax
doc: unify ERR_FALSY_VALUE_REJECTION description
a95b7de 
PR-URL: #13869
Refs: #13604
Refs: #13627
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@tniessen @addaleax
doc: unify ERR_FALSY_VALUE_REJECTION description
0fc7a50 
PR-URL: #13869
Refs: #13604
Refs: #13627
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

@tniessen tniessen

Labels
doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tniessen @jasnell @lpinca @cjihrig @MylesBorins @nodejs-github-bot