New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-stream2-basic #13146

Closed

Trott wants to merge 3 commits into nodejs:master from Trott:pummel-stream

Member

Trott commented May 21, 2017

check that noop functions are called the expected number of times
simplify assert usage
test-stream2-basic runs in a few seconds so move it to parallel so it runs in CI and in make test/vcbuild test

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

test stream

Trott added 2 commits

May 21, 2017 14:36


          test: check noop function invocations

4dc7862

In test/pummel/test-stream2-basic.js, check that noop functions are
called the expected number of times.


          test: simplify assert usage in test-stream2-basic

0b26f3a

Trott added stream test labels


          test: move stream2 test from pummel to parallel

fd82e91

test-stream2-basic runs in a few seconds. It can be moved to parallel.

Trott force-pushed the pummel-stream branch from f4b2081 to fd82e91 Compare

May 21, 2017 21:55

refack approved these changes

View reviewed changes

Contributor

refack left a comment

LGTM pending CI

Member Author

Trott commented May 22, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8222/

lpinca approved these changes

View reviewed changes

mcollina approved these changes

View reviewed changes

Member

mcollina left a comment

LGTM

cjihrig approved these changes

View reviewed changes

jasnell approved these changes

View reviewed changes

Member

addaleax commented May 24, 2017

Landed in ccd3ead...1aad4ba

addaleax closed this

addaleax pushed a commit that referenced this pull request


          test: check noop function invocations

bbd39c3

In test/pummel/test-stream2-basic.js, check that noop functions are
called the expected number of times.

PR-URL: #13146
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax pushed a commit that referenced this pull request


          test: simplify assert usage in test-stream2-basic

7bb9fd2

PR-URL: #13146
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax pushed a commit that referenced this pull request


          test: move stream2 test from pummel to parallel

1aad4ba

test-stream2-basic runs in a few seconds. It can be moved to parallel.

PR-URL: #13146
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell pushed a commit that referenced this pull request


          test: check noop function invocations

93f8ebf

In test/pummel/test-stream2-basic.js, check that noop functions are
called the expected number of times.

PR-URL: #13146
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell pushed a commit that referenced this pull request


          test: simplify assert usage in test-stream2-basic

1733ddd

PR-URL: #13146
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell pushed a commit that referenced this pull request


          test: move stream2 test from pummel to parallel

f21ae31

test-stream2-basic runs in a few seconds. It can be moved to parallel.

PR-URL: #13146
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell pushed a commit that referenced this pull request


          test: check noop function invocations

cd70a52

In test/pummel/test-stream2-basic.js, check that noop functions are
called the expected number of times.

PR-URL: #13146
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell pushed a commit that referenced this pull request


          test: simplify assert usage in test-stream2-basic

9100cac

PR-URL: #13146
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell pushed a commit that referenced this pull request


          test: move stream2 test from pummel to parallel

e012f5a

test-stream2-basic runs in a few seconds. It can be moved to parallel.

PR-URL: #13146
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell mentioned this pull request

8.0.0 Release Proposal #12220

Closed

gibfahn mentioned this pull request

Auditing for 6.11.1 nodejs/Release#230

Closed

3 tasks

MylesBorins added the land-on-v6.x label

MylesBorins pushed a commit that referenced this pull request


          test: check noop function invocations

4442a1f

In test/pummel/test-stream2-basic.js, check that noop functions are
called the expected number of times.

PR-URL: #13146
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          test: simplify assert usage in test-stream2-basic

85a8d6e

PR-URL: #13146
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          test: move stream2 test from pummel to parallel

10ad128

test-stream2-basic runs in a few seconds. It can be moved to parallel.

PR-URL: #13146
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          test: check noop function invocations

e15e2e7

In test/pummel/test-stream2-basic.js, check that noop functions are
called the expected number of times.

PR-URL: #13146
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          test: simplify assert usage in test-stream2-basic

7a5248d

PR-URL: #13146
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          test: move stream2 test from pummel to parallel

b7c7112

test-stream2-basic runs in a few seconds. It can be moved to parallel.

PR-URL: #13146
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins mentioned this pull request

v6.11.3-proposal #14852

Merged

This was referenced Sep 5, 2017

2017-09-05 Version 6.11.3 'Boron' (LTS) @MylesBorins beevelop/docker-android-nodejs#139

Closed

2017-09-05 Version 6.11.3 'Boron' (LTS) @MylesBorins beevelop/docker-android-nodejs#140

Closed

2017-09-05 Version 6.11.3 'Boron' (LTS) @MylesBorins beevelop/docker-android-nodejs#141

Closed

2017-09-05 Version 6.11.3 'Boron' (LTS) @MylesBorins beevelop/docker-android-nodejs#142

Closed

2017-09-05 Version 6.11.3 'Boron' (LTS) @MylesBorins beevelop/docker-android-nodejs#143

Closed

Trott deleted the pummel-stream branch

January 13, 2022 22:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes

refack refack approved these changes

jasnell jasnell approved these changes

lpinca lpinca approved these changes

cjihrig cjihrig approved these changes

Labels