Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: port disabled readline test #13091

Closed
wants to merge 1 commit into from
Closed

test: port disabled readline test #13091

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 18, 2017

Port the disabled readline test to make it runnable in our usual test
suite.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test readline

@Trott
test: port disabled readline test
a022c7a 
Port the disabled readline test to make it runnable in our usual test
suite.
@Trott Trott added readline Issues and PRs related to the built-in readline module. test Issues and PRs related to the tests. labels May 18, 2017
cjihrig
cjihrig approved these changes May 18, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI passes

@Trott
Copy link
Member Author

Trott commented May 20, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8209/

Trott added a commit to Trott/io.js that referenced this pull request May 21, 2017
@Trott
test: port disabled readline test
595e5e3 
Port the disabled readline test to make it runnable in our usual test
suite.

PR-URL: nodejs#13091
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member Author

Trott commented May 21, 2017

Landed in 595e5e3

@Trott Trott closed this May 21, 2017
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@Trott Trott deleted the readline branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
readline Issues and PRs related to the built-in readline module. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Trott @cjihrig @MylesBorins