test: refactor test-net-listen-shared-ports #13019
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
net
santigimeno
approved these changes
May 14, 2017
targos
approved these changes
May 14, 2017
lpinca
reviewed
May 14, 2017
| } else { | ||
| const server1 = net.createServer(common.noop); |
There was a problem hiding this comment.
Nit: does it make sense to use common.mustNotCall()?
lpinca
approved these changes
May 14, 2017
cjihrig
approved these changes
May 14, 2017
Trott
force-pushed
the
refactor-shared-ports
branch
from
5a3671c
to
ab34f9d
Compare
|
Looks like i managed to submit this PR twice. #13010 already landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
common.mustCall()to make certain that functions with assertionsrun the expected number of times.
Remove unused connection listeners from workers.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test net