Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: standard-conformant C0 control and whitespace handling #12846

Closed
wants to merge 1 commit into from
Closed

url: standard-conformant C0 control and whitespace handling #12846

wants to merge 1 commit into from

Conversation

TimothyGu
Copy link
Member

@TimothyGu TimothyGu commented May 5, 2017 •
edited
Loading

Fixes: #12825
Refs: web-platform-tests/wpt#5792

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

url

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels May 5, 2017
@TimothyGu TimothyGu mentioned this pull request May 5, 2017
Closed
@mscdex mscdex added the wip Issues and PRs that are still a work in progress. label May 5, 2017
jasnell
jasnell approved these changes May 5, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM once the other bits land.

@TimothyGu TimothyGu removed the wip Issues and PRs that are still a work in progress. label May 14, 2017
@TimothyGu
Copy link
Member Author

Upstream WPT PR was merged, this PR is ready for review :)

@TimothyGu TimothyGu changed the title WIP url: standard-conformant C0 control and whitespace handling url: standard-conformant C0 control and whitespace handling May 14, 2017
@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/8074/

@TimothyGu
Copy link
Member Author

Landed in 841bb4c.

@TimothyGu TimothyGu closed this May 20, 2017
@TimothyGu TimothyGu deleted the url-whitespace branch May 20, 2017 07:38
TimothyGu added a commit that referenced this pull request May 20, 2017
@TimothyGu
url: fix C0 control and whitespace handling
841bb4c 
PR-URL: #12846
Fixes: #12825
Refs: web-platform-tests/wpt#5792
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

url: erroneous WHATWG whitespace handling
5 participants
@TimothyGu @joyeecheung @jasnell @mscdex @nodejs-github-bot