cluster: remove debug arg handling #12738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--debug and --debug-brk are no longer valid flags so remove special handling for them in the cluster module. Even if they are restored, they will be aliases for inspect and will not use the legacy debug protocol, so the special handling will not be needed.
Trott
added
cluster
benjamingr
approved these changes
Apr 29, 2017
gibfahn
approved these changes
Apr 29, 2017
addaleax
approved these changes
Apr 29, 2017
|
What about line 108? |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 2, 2017
--debug and --debug-brk are no longer valid flags so remove special handling for them in the cluster module. Even if they are restored, they will be aliases for inspect and will not use the legacy debug protocol, so the special handling will not be needed. PR-URL: nodejs#12738 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 6, 2017
--debug and --debug-brk are no longer valid flags so remove special handling for them in the cluster module. Even if they are restored, they will be aliases for inspect and will not use the legacy debug protocol, so the special handling will not be needed. PR-URL: nodejs#12738 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--debug and --debug-brk are no longer valid flags so remove special
handling for them in the cluster module. Even if they are restored, they
will be aliases for inspect and will not use the legacy debug protocol,
so the special handling will not be needed.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
cluster debugger