src: add --napi-modules to whitelist #12733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add --napi-modules to whitelist for NODE_OPTIONS as its needed so that we can run the tests that come along with native modules.
nodejs-github-bot
added
the
c++
cjihrig
approved these changes
Apr 28, 2017
richardlau
approved these changes
Apr 28, 2017
gibfahn
approved these changes
Apr 29, 2017
benjamingr
approved these changes
Apr 29, 2017
jasnell
approved these changes
Apr 29, 2017
addaleax
approved these changes
May 3, 2017
|
Landed in 21653b6 |
addaleax
pushed a commit
that referenced
this pull request
May 3, 2017
Add --napi-modules to whitelist for NODE_OPTIONS as its needed so that we can run the tests that come along with native modules. PR-URL: #12733 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 6, 2017
Add --napi-modules to whitelist for NODE_OPTIONS as its needed so that we can run the tests that come along with native modules. PR-URL: nodejs#12733 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
3 tasks
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add --napi-modules to whitelist for NODE_OPTIONS
as its needed so that we can run the tests that
come along with native modules.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
core