test: add hasCrypto check to test-cli-node-options #12692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when configure --without-ssl the test will throw the following error: bad option: --use-openssl-ca This commit checks if crypto was enabled and skips the crypto related tests if that is the case.
mscdex
added
the
cli
lpinca
approved these changes
Apr 27, 2017
cjihrig
approved these changes
Apr 27, 2017
jasnell
approved these changes
Apr 27, 2017
sam-github
approved these changes
Apr 27, 2017
|
@nodejs/testing @nodejs/build We need a CI job, probably linux-only would be fine, that does a configure and test without SSL. This fix is only one of a string of fixes that have been made for this. Its really hard to remember such an obscure build case, sorry @danbev |
|
@sam-github it's on my list... nodejs/build#643 I'm thinking that another job that runs a variety of targets with different configurations would probably be useful, (we need |
danbev
added a commit
to danbev/node
that referenced
this pull request
Apr 29, 2017
Currently when configure --without-ssl the test will throw the following error: bad option: --use-openssl-ca This commit checks if crypto was enabled and skips the crypto related tests if that is the case. PR-URL: nodejs#12692 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>/
|
Landed in 427cd29 |
This was referenced Jun 15, 2017
|
Should land with #12677 |
This was referenced Jun 22, 2023
This was referenced Jun 22, 2023
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when configure --without-ssl the test will throw the following
error:
bad option: --use-openssl-caThis commit checks if crypto was enabled and skips the crypto related
tests if that is the case.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test