doc: modernize and fix code examples in readline.md #12634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
jasnell
approved these changes
Apr 25, 2017
lpinca
approved these changes
Apr 25, 2017
cjihrig
approved these changes
Apr 25, 2017
Add spaces between output and input for better readability.
|
Rebased to test new linter CI: https://ci.nodejs.org/job/node-test-linter/8560/ |
vsemozhetbyt
added a commit
that referenced
this pull request
Apr 26, 2017
* Improve UX in 2 code examples (add spaces between output and input for better readability). * Replace indexOf() by startsWith(). PR-URL: #12634 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
Landed in 35d2137 |
|
Oops. Sorry, typo in the commit message: |
3 tasks
gibfahn
pushed a commit
that referenced
this pull request
Jun 18, 2017
* Improve UX in 2 code examples (add spaces between output and input for better readability). * Replace indexOf() by startsWith(). PR-URL: #12634 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gibfahn
pushed a commit
that referenced
this pull request
Jun 20, 2017
* Improve UX in 2 code examples (add spaces between output and input for better readability). * Replace indexOf() by startsWith(). PR-URL: #12634 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2017
* Improve UX in 2 code examples (add spaces between output and input for better readability). * Replace indexOf() by startsWith(). PR-URL: #12634 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc, readline
indexOf()bystartsWith().