Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: fix chunky client benchmark execution #1257

Closed
wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Mar 25, 2015

This commit fixes a few things for this benchmark:

  1. Ensures the temporary directory for the unix socket exists.
  2. Prevents the client code from being run directly because the server script is the one that calls out the client code. This is done by simply renaming the client script.
  3. Ensures the server is closed once the client benchmarks have finished.
  4. Since this is an http benchmark, it should be moved to the http benchmarks subdirectory.

@mscdex mscdex added http Issues or PRs related to the http subsystem. benchmark Issues and PRs related to the benchmark subsystem. labels Mar 25, 2015
@mscdex
Copy link
Contributor Author

mscdex commented Mar 25, 2015

It seems there is another issue yet.... fix coming soon.

This commit fixes a few things for this benchmark:

1. Ensures the temporary directory for the unix socket exists.
2. Prevents the client code from being run directly because the
server script is the one that calls out the client code.
3. Ensures the server is closed once the client benchmarks have
finished.
4. Since this is an http benchmark, it should be moved to the http
benchmarks subdirectory.
@mscdex
Copy link
Contributor Author

mscdex commented Mar 25, 2015

Ok it should be sorted out now.

@silverwind
Copy link
Contributor

LGTM

mscdex added a commit that referenced this pull request Apr 3, 2015
This commit fixes a few things for this benchmark:

1. Ensures the temporary directory for the unix socket exists.
2. Prevents the client code from being run directly because the
server script is the one that calls out the client code.
3. Ensures the server is closed once the client benchmarks have
finished.
4. Since this is an http benchmark, it should be moved to the http
benchmarks subdirectory.

PR-URL: #1257
Reviewed-By: Roman Reiss <me@silverwind.io>
@mscdex
Copy link
Contributor Author

mscdex commented Apr 3, 2015

Landed in a081c7c.

@mscdex mscdex closed this Apr 3, 2015
@mscdex mscdex deleted the fix-http-benchmark branch December 17, 2015 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants