build: disable -O3 for C++ coverage #12406
Conversation
The `cflags` for `--coverage` included `-O0` so far, but that was overridden by a later `-O3`. Resolve that by adding `'cflags!': [ '-O3' ]` and increase coverage accuracy.
nodejs-github-bot
added
the
build
|
P.S. did you notice that when |
|
P.S. wouldn't this be more interesting: https://ci.nodejs.org/job/node-test-commit-linux-coverage/221/ |
Yup… I guess gyp ist just being gyp.
Yes! I didn’t know that existed. :) |
|
In term of running the job for coverage we've not generally publicized that you can start a job on your own branch as it will push the results out to the website and that might lead to some confusing up/downs on coverage.nodejs.org. Having said that, this is probably a case where it does make sense. |
|
From Job 221 Makes sense? |
|
@mhdawson Oh, yes, thanks for explaining that it does that! 😄 Did this end up getting pushed to the website, though? I don’t see it at https://coverage.nodejs.org/, but the run seems to have completed. (If it does end up there: Maybe we should merge this sooner than later? Otherwise it just gets more confusing, and this patch is not, like, overly complex or anything…) |
Oops 😟 I'm used to CIs being very selective in terms of publishing from non-master |
Yes. The overall C++ coverage is a bit lower than previously, but that seems to be because the compiler now adds coverage support for more lines that were previously optimized away (for example, line 23 in base64.h which is obviously pointless to actually execute). |
|
On the site first line is:
|
|
@refack that is a a good idea, I should look at updating the job to only publish if it was started off master, will add that to my TODO list. |
If you point me to where, I'd be happy to help. |
|
In terms of the difference in coverage numbers it just sounds like something we'll have to live with, we can probably let people know why this change occurred and move on unless we have a better idea. |
|
@mhdawson See #12406 (comment) – I just looked at a few examples but it would make sense if that was the general reason for it |
|
@refack the ability to change the CI jobs is limited to the build team except for some WG specific jobs so you won't be able to edit it. But if you have some sample jenkins shell script code (we currently only generate the results on linux) that does the check from another project send it to me and I can probably just paste it in. Otherwise I don't think it will take me too long to put it together. |
|
@addaleax I was responding you your comment (guess I could have said that :)), makes sense to me. |
|
The results do get pushed at an interval, I can't remember exactly now but its at least once a night (might be every 6 hours, I could look it up). I could go delete the result, but I'd vote for just pushing the change. |
|
I'm landing some, I'll land this as well. |
|
Landed in ea44b8b |
The `cflags` for `--coverage` included `-O0` so far, but that was overridden by a later `-O3`. Resolve that by adding `'cflags!': [ '-O3' ]` and increase coverage accuracy. Ref: https://coverage.nodejs.org/ PR-URL: #12406 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The `cflags` for `--coverage` included `-O0` so far, but that was overridden by a later `-O3`. Resolve that by adding `'cflags!': [ '-O3' ]` and increase coverage accuracy. Ref: https://coverage.nodejs.org/ PR-URL: #12406 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The `cflags` for `--coverage` included `-O0` so far, but that was overridden by a later `-O3`. Resolve that by adding `'cflags!': [ '-O3' ]` and increase coverage accuracy. Ref: https://coverage.nodejs.org/ PR-URL: #12406 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The `cflags` for `--coverage` included `-O0` so far, but that was overridden by a later `-O3`. Resolve that by adding `'cflags!': [ '-O3' ]` and increase coverage accuracy. Ref: https://coverage.nodejs.org/ PR-URL: #12406 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The
cflagsfor--coverageincluded-O0so far, but that wasoverridden by a later
-O3. Resolve that by adding'cflags!': [ '-O3' ]and increase coverage accuracy.CI: https://ci.nodejs.org/job/node-test-commit/9087/
/cc @mhdawson @CurryKitten