Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n-api: fix coverity scan report #12365

Closed
wants to merge 1 commit into from
Closed

Conversation

mhdawson
Copy link
Member

Coverity was reporting _request.work_req as not being initialized.
Add memset to ensure all of _request is initialized.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]
Affected core subsystem(s)

n-api

Coverity was reporting _request.work_req as not being initialized.
Add memset to ensure all of _request is initialized.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. labels Apr 12, 2017
@mhdawson mhdawson self-assigned this Apr 12, 2017
@mhdawson
Copy link
Member Author

I'm thinking this is not controversial so likely does not need the 48hours waiting period

addaleax pushed a commit to addaleax/node that referenced this pull request Apr 14, 2017
Coverity was reporting _request.work_req as not being initialized.
Add memset to ensure all of _request is initialized.

PR-URL: nodejs#12365
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@addaleax
Copy link
Member

Landed in 46f2026

@addaleax addaleax closed this Apr 14, 2017
@jasnell jasnell mentioned this pull request May 11, 2017
@mhdawson mhdawson deleted the napi-cov3 branch June 28, 2017 19:24
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
Coverity was reporting _request.work_req as not being initialized.
Add memset to ensure all of _request is initialized.

PR-URL: nodejs#12365
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
Coverity was reporting _request.work_req as not being initialized.
Add memset to ensure all of _request is initialized.

Backport-PR-URL: #19447
PR-URL: #12365
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants