Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: drop PPC BE from supported platforms #12309

Closed
wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

We've discussed this with the Power team within IBM and have
agreement that we should drop Power Linux BE for Node version
8 as customers will be using Power Linux LE when using
Node.js going forward.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows [commit guidelines]
Affected core subsystem(s)

doc

We've discussed this with the Power team within IBM and have
agreement that we should drop Power Linux BE for Node version
8 as customers will be using Power Linux LE when using
Node.js going forward.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Apr 10, 2017
@mscdex mscdex added the ppc Issues and PRs related to the Power architecture. label Apr 10, 2017
@gibfahn
Copy link
Member

gibfahn commented Apr 10, 2017

cc/ @nodejs/platform-ppc

Copy link
Member

@gdams gdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

refack added a commit to refack/build that referenced this pull request Apr 10, 2017
@refack
Copy link
Contributor

refack commented Apr 10, 2017

Ref: nodejs/build#680

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM but just thinking... do we need a proper deprecation cycle for dropping support for a platform? Does that even make sense?

@mhdawson
Copy link
Member Author

@jasnell in general I think the more warning we can give people the better. This may be a bit of a special situation where Power Linux essentially switched the primary endianess and there were both options for a transition period. I suggest we land this but then discuss in the LTS team what we want the standard process to be. We should probably also do the same in terms of OS versions.

@mhdawson
Copy link
Member Author

will plan to land unless I hear objections once the 24 hours is up.

@jasnell
Copy link
Member

jasnell commented Apr 11, 2017

Sounds good

@mhdawson
Copy link
Member Author

mhdawson added a commit that referenced this pull request Apr 12, 2017
We've discussed this with the Power team within IBM and have
agreement that we should drop Power Linux BE for Node version
8 as customers will be using Power Linux LE when using
Node.js going forward.

PR-URL: #12309
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Jaideep Bajwa <bjaideep@ca.ibm.com>
@mhdawson
Copy link
Member Author

Landed in 75c471a

@mhdawson mhdawson closed this Apr 12, 2017
@evanlucas evanlucas added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 25, 2017
@jasnell jasnell mentioned this pull request May 11, 2017
@mhdawson mhdawson deleted the dropbe branch June 28, 2017 19:24
@richardlau richardlau mentioned this pull request Feb 23, 2018
2 tasks
@sam-github
Copy link
Contributor

For the record, this means we stopped releasing builds for ppc64 (which is big-endian) in:

  • 8.9.2 and later on 8.x
  • 9.2.1 and later on 9.x
  • 10.0.0 and later for 10.x, 11.x, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. ppc Issues and PRs related to the Power architecture. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.