Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: support dtrace on ARM #12193

Conversation

bradleythughes
Copy link
Member

Use the same dtrace command on ARM as on i386. Patch obtained from
FreeBSD PR 218081 [1].

  1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218081
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Use the same dtrace command on ARM as on i386. Patch obtained from
FreeBSD PR 218081 [1].

1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218081
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Apr 3, 2017
@vsemozhetbyt vsemozhetbyt added the arm Issues and PRs related to the ARM platform. label Apr 3, 2017
@vsemozhetbyt
Copy link
Contributor

@jasnell
Copy link
Member

jasnell commented Apr 18, 2017

@lpinca
Copy link
Member

lpinca commented May 27, 2017

@lpinca
Copy link
Member

lpinca commented May 27, 2017

Landed in f84666f.

@lpinca lpinca closed this May 27, 2017
lpinca pushed a commit that referenced this pull request May 27, 2017
Use the same dtrace command on ARM as on i386. Patch obtained from
FreeBSD PR 218081 [1].

1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218081

PR-URL: #12193
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request May 28, 2017
Use the same dtrace command on ARM as on i386. Patch obtained from
FreeBSD PR 218081 [1].

1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218081

PR-URL: #12193
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell mentioned this pull request May 28, 2017
@bradleythughes bradleythughes deleted the configure-support-dtrace-on-arm branch May 31, 2017 11:01
@bradleythughes bradleythughes restored the configure-support-dtrace-on-arm branch May 31, 2017 11:01
@bradleythughes bradleythughes deleted the configure-support-dtrace-on-arm branch June 1, 2017 18:02
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
3 tasks
@MylesBorins
Copy link
Contributor

Should this be enabled for v6.x?

@bradleythughes
Copy link
Member Author

Hi, sorry for the late response (vacation). Ideally, yes, this should be in 6.x as well.

MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
Use the same dtrace command on ARM as on i386. Patch obtained from
FreeBSD PR 218081 [1].

1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218081

PR-URL: #12193
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
Use the same dtrace command on ARM as on i386. Patch obtained from
FreeBSD PR 218081 [1].

1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218081

PR-URL: #12193
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Issues and PRs related to the ARM platform. build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants