Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

napi: break dep between v8 and napi attributes #12191

Closed
wants to merge 3 commits into from
Closed

napi: break dep between v8 and napi attributes #12191

wants to merge 3 commits into from

Commits on Apr 4, 2017

  1. n-api: break dep between v8 and napi attributes 

    The v8 n-api implementation had been depending on a one-to-one
relationship between v8 and n-api v8 property attributes.
Remove this dependency and fix coverity scan issue
165845.
    @mhdawson
    mhdawson committed Apr 4, 2017
    Configuration menu
    Copy the full SHA
    f2315a9 View commit details
    Browse the repository at this point in the history

  2. squash: address comments

    @mhdawson
    mhdawson committed Apr 4, 2017
    Configuration menu
    Copy the full SHA
    444b519 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2017

  1. squash: address suggestion

    @mhdawson
    mhdawson committed Apr 5, 2017
    Configuration menu
    Copy the full SHA
    fbcc3c6 View commit details
    Browse the repository at this point in the history