Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add coverage for child_process bounds check #11800

Closed
wants to merge 3 commits into from
Closed

test: add coverage for child_process bounds check #11800

wants to merge 3 commits into from

Commits on Mar 17, 2017

  1. test: add coverage for child_process bounds check 

    Make sure that monkey-patching process.execArgv doesn't cause
child_process to incorrectly munge execArgv in fork().

This basically is adding coverage for an `index > 0` check (see Refs).
Previously, that condition was never false in any of the tests.

Refs: https://github.com/nodejs/node/blob/c67207731f16a78f6cae90e49c53b10728241ecf/lib/child_process.js#L76
    @Trott
    Trott committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    bf8a998 View commit details
    Browse the repository at this point in the history

  2. squash: hopeful fix for Windows

    @Trott
    Trott committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    c2a2dc2 View commit details
    Browse the repository at this point in the history

  3. squash: make it one line and see if that fixes it on Windows

    @Trott
    Trott committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    f28a356 View commit details
    Browse the repository at this point in the history