Commits on Feb 28, 2017

1. tools: remove NODE_PATH from environment for tests …

   Unset NODE_PATH environment variable when running tests.
   
   On Ubuntu 16.04, some users experience test failures due to internal
   libraries being installed in /usr/lib/nodejs/internal and NODE_PATH
   including /usr/lib/nodejs. Tests that expect internal libraries to be
   off limits without the --expose-internals flag will fail in this
   situation. Currently, those tests are test/parallel/test-repl.js and
   test/parallel/test-internal-modules.js.
   
   This situation seems to (probably) be caused by some
   not-entirely-uncommon package that gets installed.
   
   Regardless, tests should ignore the user's NODE_PATH. (NODE_PATH is
   tested in test/parallel/test-module-globalpaths-nodepath.js and
   test/parallel/test-require-dot.js.)
   
   Refs: https://twitter.com/trott/status/835729396900061184

   

   Trott committed Feb 28, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for c99ba2d
   • Browse repository at this point

   Copy the full SHA

   c99ba2d View commit details

   Browse the repository at this point in the history