tools: enable one-var-declaration-per-line ESLint rule #11462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule enforces new lines around variable declarations. It is configured to spot only variables that are initialized.
nodejs-github-bot
added
child_process
jasnell
approved these changes
Feb 19, 2017
hiroppy
approved these changes
Feb 19, 2017
gibfahn
approved these changes
Feb 20, 2017
lpinca
reviewed
Feb 20, 2017
| @@ -12,14 +12,14 @@ var gargs = [1, 2, 3]; | |||
|
|
|||
| function main(conf) { | |||
|
|
|||
| var args, n = +conf.n; | |||
There was a problem hiding this comment.
Nit: any reason for putting this in for block instead of keeping it here on a separate line?
There was a problem hiding this comment.
I think it's clearer to declare it in the block where it's used
There was a problem hiding this comment.
Yeah but var is not block scoped so I think this only create confusion for newbies. Can const be used instead?
There was a problem hiding this comment.
OK, I'll change it to const.
lpinca
approved these changes
Feb 21, 2017
targos
added a commit
to targos/node
that referenced
this pull request
Feb 21, 2017
This rule enforces new lines around variable declarations. It is configured to spot only variables that are initialized. PR-URL: nodejs#11462 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 1934686 |
addaleax
pushed a commit
that referenced
this pull request
Feb 22, 2017
This rule enforces new lines around variable declarations. It is configured to spot only variables that are initialized. PR-URL: #11462 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
|
This would require a backport PR to land in v6 or v4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule enforces new lines around variable declarations. It is
configured to spot only variables that are initialized.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
benchmark, lib, test, tools