Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v7.x backport) URL-related changes #11457

Closed
wants to merge 8 commits into from

Conversation

TimothyGu
Copy link
Member

Backports of:

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

url

joyeecheung and others added 8 commits February 18, 2017 11:39
* attributon of WPT in url-setter-tests
* add WPT test utilities
* synchronize WPT URLSearchParams tests
* synchronize WPT url tests
* split whatwg-url-inspect test
* port historical url tests from WPT
* protocol setter and special URLs

Refs: web-platform-tests/wpt#4413
Refs: whatwg/url#104
Backport-of: nodejs#11079
Also factor out common parts in querystring and url.

Backport-of: nodejs#11161
Also remove executable bit from doc/api/url.md's mode.

Backport-of: nodejs#11330
Fixes: 84e2ff3 "doc: add basic documentation for WHATWG URL API"
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. dont-land-on-v4.x querystring Issues and PRs related to the built-in querystring module. url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Feb 18, 2017
@TimothyGu TimothyGu added the semver-minor PRs that contain new features and should be released in the next minor version. label Feb 18, 2017
@TimothyGu
Copy link
Member Author

@targos
Copy link
Member

targos commented Feb 18, 2017

I'm surprised so many backports are necessary for this feature. Isn't there a previous missing commit that would fix the merge conflicts?

@italoacasas
Copy link
Contributor

Yeap, the problem is that #11060 is landed in master but currently is being discussed in the spec repo whatwg/url#204.

@italoacasas
Copy link
Contributor

@TimothyGu thanks for the backport I will review it over the weekend.

@italoacasas
Copy link
Contributor

Landed in staging. Thanks for taking the time @TimothyGu

@TimothyGu TimothyGu deleted the url-v7 branch February 20, 2017 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. querystring Issues and PRs related to the built-in querystring module. semver-minor PRs that contain new features and should be released in the next minor version. url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants