Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: cleanup internalUtil.deprecate #11450

Closed
wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Feb 17, 2017

There were two functions deprecate and _deprecate that were really just aliases of each other. Simplify

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

internal util

@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Feb 17, 2017
@jasnell
Copy link
Member Author

jasnell commented Feb 18, 2017

@jasnell
Copy link
Member Author

jasnell commented Feb 19, 2017

CI results were a bit weird, trying again: https://ci.nodejs.org/job/node-test-pull-request/6500/

There were two functions `deprecate` and `_deprecate`
that were really just aliases of each other. Simplify
jasnell added a commit that referenced this pull request Feb 19, 2017
There were two functions `deprecate` and `_deprecate`
that were really just aliases of each other. Simplify

PR-URL: #11450
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Feb 19, 2017

Landed in 0510472

@jasnell jasnell closed this Feb 19, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 25, 2017
There were two functions `deprecate` and `_deprecate`
that were really just aliases of each other. Simplify

PR-URL: nodejs#11450
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 25, 2017
@jasnell
Copy link
Member Author

jasnell commented Mar 7, 2017

note to self... this will need a backport PR for 6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants