lib: refactor some lib/internals #11406
Conversation
nodejs-github-bot
added
the
lib / src
lib/internal/freelist.js
Outdated
|
|
||
| alloc() { | ||
| return this.list.length ? this.list.pop() : | ||
| this.constructor.apply(this, arguments); |
There was a problem hiding this comment.
Unrelated to this PR, but perhaps this can be simplified since http is the only user of FreeList and we'd know how what arguments to pass on to the constructor. I'm not sure if adding new would help (allowing us to avoid an instanceof check in the constructor if possible) more than it might hurt (e.g. if stack traces would change with new constructor(..)).
There was a problem hiding this comment.
Worth playing around with. I would also note that I had attempted to replace this use of arguments with ...args, but found that in the case there are no arguments passed to the alloc(), it caused a whopping 48% slowdown. Definitely something we'll need to keep in mind.
lib/internal/net.js
Outdated
| @@ -11,8 +9,12 @@ function isLegalPort(port) { | |||
| return +port === (+port >>> 0) && port <= 0xFFFF; | |||
| } | |||
|
|
|||
|
|
|||
lib/internal/freelist.js
Outdated
| class FreeList { | ||
| constructor(name, max, constructor) { | ||
| this.name = name; | ||
| this.constructor = constructor; |
There was a problem hiding this comment.
Naming own properties of instances constructor is kind of confusing, maybe you could change that while you’re here?
lib/internal/socket_list.js
Outdated
| constructor(slave, key) { | ||
| super(); | ||
| this.key = key; | ||
| this.slave = slave; |
There was a problem hiding this comment.
Likewise, it would be awesome if we could change this during the refactor (here and in the other parts of the file this PR touches).
Switch to using the more efficient module.exports = {}
where possible.
jasnell
force-pushed
the
refactor-internals
branch
from
ebd64f5
to
be22262
Compare
jasnell
added
the
semver-major
|
semver-major because an error message is changed. |
PR-URL: #11406 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #11406 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #11406 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Switch to using the more efficient module.exports = {}
where possible.
PR-URL: #11406
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
Landed in d61a511...62e9609 |
Some light refactoring of internals/*.js
(do not squash commits)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
lib/internal